Review main Merged

76809[TASK] Make docheader finally embrace flexbox

Benjamin Kott CR +2 V +2 Hard +81 −176 updated 11/25/22, 10:03

Commit message

The conversion to flexbox is now complete. Spacing is now
streamlined and hard limits for columns removed. SCSS-Variables
are converted to plain CSS-Variables. Compiling dependencies to
the Form and Dashboard module are now resolved.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 912

  1. Benjamin Kott uploaded patch set 1 11/24/22, 15:20

  2. core-ci voted on patch set 1 V +1 11/24/22, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34174

  3. Benni Mack commented on patch set 1 11/24/22, 19:35

    DocHeader.html:8

    seems like a duplicate with line 20 now?
  4. Benjamin Kott commented on patch set 1 11/25/22, 06:42

    DocHeader.html:8 Reply

    will check again
  5. Benjamin Kott uploaded patch set 2 V +1 11/25/22, 07:56

  6. Benjamin Kott uploaded patch set 3 11/25/22, 08:01

  7. Benjamin Kott commented on patch set 3 11/25/22, 08:03

    DocHeader.html:8 Reply

    checked again, we can unify a lot more and remove extra renderings as well
  8. core-ci voted on patch set 2 V +1 11/25/22, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34196

  9. core-ci voted on patch set 3 V +1 11/25/22, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34197

  10. Benni Mack voted on patch set 3 V +1 CR +1 11/25/22, 09:58

  11. Georg Ringer voted on patch set 3 V +2 CR +2 11/25/22, 10:03

  12. Georg Ringer merged patch set 4 11/25/22, 10:03