Review main Merged

76818[TASK] Allow modals to stay open after invoking an action

Andreas Kienast CR +2 V +2 Easy +24 −7 updated 11/25/22, 10:10

Commit message

A new enum `PostActionModalBehavior` is added to allow control whether
a modal window should stay open after invoking either an
`ImmediateAction` or `DeferredAction`.

Such action may return any value of `PostActionModalBehavior`, namely
`KEEP_OPEN` or `CLOSE`. If nothing is provided, the default behavior is
to close the modal.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1014

  1. Andreas Kienast uploaded patch set 1 11/25/22, 08:42

  2. core-ci voted on patch set 1 V -1 11/25/22, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34200

  3. Andreas Kienast uploaded patch set 2 V -1 11/25/22, 09:26

  4. Andreas Kienast uploaded patch set 3 11/25/22, 09:29

  5. core-ci voted on patch set 2 V +1 11/25/22, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34201

  6. Andreas Kienast commented on patch set 3 CR -2 11/25/22, 09:36

  7. Andreas Kienast uploaded patch set 4 11/25/22, 09:37

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  8. core-ci voted on patch set 3 V +1 11/25/22, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34202

  9. core-ci voted on patch set 4 V +1 11/25/22, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34203

  10. Andreas Kienast voted on patch set 4 CR 0 11/25/22, 09:46

  11. Benni Mack voted on patch set 4 V +1 CR +1 11/25/22, 10:04

  12. Anja Leichsenring voted on patch set 4 V +1 CR +1 11/25/22, 10:10

  13. Andreas Kienast voted on patch set 4 V +2 CR +2 11/25/22, 10:10

  14. Andreas Kienast merged patch set 5 11/25/22, 10:10