Review main Merged

76821[TASK] Re-organize PageLayoutController

Benni Mack CR +2 V +2 Normal +112 −104 updated 11/25/22, 15:01

Commit message

This change cleans up various parts of
PageLayoutController that are leftovers due to
the usage of PageLayoutView (which is now removed),
and Fluid-based Page module.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1622

  1. Benni Mack uploaded patch set 1 11/25/22, 12:34

  2. Benni Mack uploaded patch set 2 11/25/22, 12:38

  3. Susi Moog voted on patch set 2 V +1 CR +1 11/25/22, 12:45

  4. core-ci voted on patch set 1 V -1 11/25/22, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34212

  5. Andreas Kienast commented on patch set 2 11/25/22, 12:50

    PageLayoutController.php:186

    What about ``` $this->availableLanguages[0]?->getTitle() ?? $languageService->getLL('m_default') ```
  6. Benni Mack commented on patch set 3 CR +1 V +1 11/25/22, 12:52

    Published edit on patch set 2.
  7. Benni Mack commented on patch set 3 11/25/22, 12:54

    PageLayoutController.php:186 Reply

    Done
  8. core-ci voted on patch set 2 V -1 11/25/22, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34213

  9. core-ci voted on patch set 3 V -1 11/25/22, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34220

  10. Andreas Kienast rebased onto patch set 4 V -1 11/25/22, 14:07

  11. Andreas Kienast voted on patch set 4 V +1 CR +1 11/25/22, 14:10

  12. Benni Mack uploaded patch set 5 CR +1 V +1 11/25/22, 14:18

  13. Andreas Kienast voted on patch set 5 V +1 CR +1 11/25/22, 14:22

  14. core-ci voted on patch set 4 V -1 11/25/22, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34226

  15. Georg Ringer voted on patch set 5 V +1 CR +1 11/25/22, 14:29

  16. core-ci voted on patch set 5 V -1 11/25/22, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34228

  17. Benni Mack rebased onto patch set 6 CR +1 V +1 11/25/22, 14:39

  18. core-ci voted on patch set 6 V +1 11/25/22, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34233

  19. Andreas Kienast voted on patch set 6 V +1 CR +1 11/25/22, 14:48

  20. Georg Ringer voted on patch set 6 V +1 CR +1 11/25/22, 15:00

  21. Benni Mack voted on patch set 6 V +2 CR +2 11/25/22, 15:01

  22. Benni Mack merged patch set 7 11/25/22, 15:01