Review main Merged

76827[BUGFIX] Show to top/bottom icons if size of element is 2 or greater

Georg Ringer CR +2 V +2 Easy +6 −6 updated 07/24/24, 10:34

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 3243

Show 1418 earlier messages
  1. Georg Ringer uploaded patch set 1 11/25/22, 15:40

  2. Georg Ringer commented on patch set 1 11/25/22, 15:40

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 11/25/22, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34235

  4. Oliver Klee commented on patch set 1 11/25/22, 15:51

    GroupElement.php:307

    We're currently having the same magic number hardcoded in multiple places. Please let's move that to a central, well-named PHP constant so we have the number in only one place.
  5. Georg Ringer commented on patch set 1 11/25/22, 15:54

    GroupElement.php:307 Reply

    sorry this doesn't make sense. just look at the code around, it is not the number which is getting repeated but the nearly the complete generation of up/down/to top/to bottom lists. if we want some less duplications that could be handled but this change is not about that.
  6. Oliver Klee commented on patch set 1 11/25/22, 16:11

    GroupElement.php:307 Reply

    Would it make sense for the numbers in the different places to be different?
  7. Georg Ringer commented on patch set 1 11/26/22, 09:06

    GroupElement.php:307 Reply

    IMO no
  8. Oliver Klee commented on patch set 1 11/26/22, 09:19

    GroupElement.php:307 Reply

    Then we should indeed have those numbers in a central place (event if we don't reduce duplication in code that is not touched by this change).
  9. Sebastian Iffland updated the commit message in patch set 2 V +1 11/28/22, 16:49

  10. core-ci voted on patch set 2 V +1 11/28/22, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34331

  11. Stefan Froemken commented on patch set 2 12/02/22, 22:41

    If size is set to a value higher than 1 the listbox will be set to select[size]:not([size="1"]) { min-height: 156px; } by CSS. That height reserves place for 10 entries. So, setting the default size to 2, if size is not given, does not make sense for me. IMO we should increase values of 2-9 to 10 by default to match the CSS property. With this new default we will always match the hard-coded 5. Instead of reducing that value I would prefer to increase size to at least 10 und adapt the hard-coded value to 10, too.
  12. Benni Mack updated the commit message in patch set 3 V +1 05/03/23, 09:26

  13. core-ci voted on patch set 3 V -1 05/03/23, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41412

  14. Oliver Hader rebased onto patch set 4 V -1 05/03/23, 12:39

  15. core-ci voted on patch set 4 V -1 05/03/23, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41531

  16. Nikita Hovratov commented on patch set 4 05/03/23, 16:20

    GroupElement.php:307 Reply

    Just my two cents: The Form Element classes have duplicated code by intention. It is much easier to understand and follow the code, if you don't need to jump through common abstract classes. This is a good example, where you should prefer WET over DRY.
  17. Oliver Klee commented on patch set 4 05/03/23, 16:29

    GroupElement.php:307 Reply

    I was thinking more of constants in the concrete classes (unless the size limit of 3 here and in line 282 is the same by chance, but it could also be different). What is the case here? Does the size limit here and in line 282 always be the same, or could it also be different?
  18. Georg Ringer commented on patch set 4 08/23/23, 19:10

    GroupElement.php:307 Reply

    for the sake of getting this done: where would you locate such constant if all of those elements are independent?
  1. Oliver Klee commented on patch set 4 08/23/23, 19:29

    GroupElement.php:307 Reply

    If the all instances of the number 3 in this change are independent (and could be all different numbers in theory), there is no need for a constant. If they always need to be the same number (within the same class), though, I’d say we put them in the corresponding class (in this case, GroupElement and FolderElement).
  2. Georg Ringer commented on patch set 4 08/23/23, 20:12

    GroupElement.php:307 Reply

    why not for SelectMultipleSideBySideElement?
  3. Oliver Klee commented on patch set 4 08/23/23, 21:18

    GroupElement.php:307 Reply

    Honestly, I don‘t really care where the constant end up as long as we move the numbers in that change that always need to be the same into contants. So I’d be fine with that class as well.
  4. Georg Ringer uploaded patch set 5 V -1 08/24/23, 12:17

  5. core-ci voted on patch set 5 V -1 08/24/23, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45785

  6. Georg Ringer rebased onto patch set 6 V -1 09/22/23, 12:30

  7. core-ci voted on patch set 6 V -1 09/22/23, 12:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47086

  8. Oliver Klee commented on patch set 6 09/22/23, 14:08

    GroupElement.php:307 Reply

    Done
  9. Oliver Klee wrote 10/08/23, 13:23

    Removed cc Oliver Klee.
  10. Georg Ringer rebased onto patch set 7 V -1 03/29/24, 10:06

  11. core-ci voted on patch set 7 V -1 03/29/24, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55059

  12. Stefan Froemken uploaded patch set 8 V -1 06/23/24, 14:17

  13. Stefan Froemken rebased onto patch set 9 06/23/24, 14:20

  14. core-ci voted on patch set 8 V -1 06/23/24, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60110

  15. core-ci voted on patch set 9 V +1 06/23/24, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60111

  16. Stefan Froemken rebased onto patch set 10 V +1 07/11/24, 11:57

  17. core-ci voted on patch set 10 V +1 07/11/24, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61380

  18. Christian Kuhn commented on patch set 10 CR -1 07/11/24, 18:32

    Had a quick look at this: When size is > 1 (1 is a common and valid setup for n:1 group relations), then css gives a min-height of 156px currently. I'd say, we should remove this arbitrary "5" restriction completely and always show the move icons if not explicitly disabled: "if ($maxItems > 1 && $size > 1 && $showMoveIcons) {" What do you think?
  19. Georg Ringer uploaded patch set 11 CR -1 V +1 07/23/24, 12:38

  20. Christian Kuhn commented on patch set 11 CR +1 V +1 07/23/24, 12:42

    Reply

    Done
  21. core-ci voted on patch set 11 V +1 07/23/24, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62007

  22. Nikita Hovratov voted on patch set 11 CR +1 07/23/24, 13:28

  23. Jasmina Ließmann voted on patch set 11 CR +1 V +1 07/23/24, 13:47

  24. Georg Ringer voted on patch set 11 CR +2 V +2 07/24/24, 10:34

  25. Georg Ringer merged patch set 12 07/24/24, 10:34