Review main Merged

76830[TASK] Replace prophecy in EXT:form RedirectFinisherTest

Torben Hansen CR +2 V +2 Easy +16 −20 updated 11/25/22, 19:14

Commit message

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Torben Hansen uploaded patch set 1 11/25/22, 18:02

  2. core-ci voted on patch set 1 V +1 11/25/22, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34241

  3. Nikita Hovratov commented on patch set 1 11/25/22, 18:47

    RedirectFinisherTest.php:68

    should be self::once()
  4. Torben Hansen uploaded patch set 2 V +1 11/25/22, 18:50

  5. Torben Hansen commented on patch set 1 11/25/22, 18:50

    RedirectFinisherTest.php:68 Reply

    Done
  6. Oliver Klee voted on patch set 2 CR +1 11/25/22, 18:55

  7. core-ci voted on patch set 2 V +1 11/25/22, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34243

  8. Oliver Klee voted on patch set 2 V +1 11/25/22, 19:11

  9. Nikita Hovratov voted on patch set 2 V +2 CR +2 11/25/22, 19:14

  10. Nikita Hovratov merged patch set 3 11/25/22, 19:14