76831[TASK] Replace prophecy in EXT:form AbstractFinisherTest
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 67
-
Torben Hansen uploaded patch set 1 11/25/22, 18:48
-
Oliver Klee commented on patch set 1 11/25/22, 18:55
AbstractFinisherTest.php:179Here, we should have the with(self::anything()) to keep the previous checks (unless the methods actually are called without arguments - haven't checked).AbstractFinisherTest.php:224Here, we should have the with(self::anything()) to keep the previous checks (unless the methods actually are called without arguments - haven't checked). -
core-ci voted on patch set 1 V +1 11/25/22, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34242
-
Torben Hansen commented on patch set 1 11/26/22, 04:52
AbstractFinisherTest.php:134Reply`getFinisherVariableProvider()` function in `FinisherContext` does not have any arguments. See https://github.com/TYPO3/typo3/blob/main/typo3/sysext/form/Classes/Domain/Finishers/FinisherContext.php#L101AbstractFinisherTest.php:179Reply`getFormRuntime()` function in `FinisherContext` does not have any arguments. See https://github.com/TYPO3/typo3/blob/main/typo3/sysext/form/Classes/Domain/Finishers/FinisherContext.php#L88AbstractFinisherTest.php:224Reply`getFormRuntime()` function in `FinisherContext` does not have any arguments. See https://github.com/TYPO3/typo3/blob/main/typo3/sysext/form/Classes/Domain/Finishers/FinisherContext.php#L88 -
Oliver Klee commented on patch set 1 V +1 CR +1 11/26/22, 08:19
AbstractFinisherTest.php:134ReplyAckAbstractFinisherTest.php:179ReplyAckAbstractFinisherTest.php:224ReplyAck -
Nikita Hovratov voted on patch set 1 V +2 CR +2 11/26/22, 13:04
-
Nikita Hovratov merged patch set 2 11/26/22, 13:05
AbstractFinisherTest.php:134