Review main Abandoned

76837[TASK] Remove prepare containers for functional and acceptance tests

Stefan Bürk CR 0 V 0 Hard +104 −176 updated 11/26/22, 20:43

Commit message

`Build/Script/runTests.sh` used dedicated prepare container spawns
for functional, deprecated functional, acceptance application and
acceptance install tests. Main purpose of these prepare images was
to wait for database to spawn up.

Experience with couple of extensions like ext:styleguide showed,
that having this in the test container directly is reliable enough.

This change removes corresponding `prepare_*` service definitions
from `docker-compose.yml`, moving the wait commands along with the
needed links to the testing service container. Thus `runTests.sh`
is adjusted accordingly not calling the prepare services anymore.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 34

  1. Stefan Bürk uploaded patch set 1 11/26/22, 16:45

  2. Stefan Bürk uploaded patch set 2 11/26/22, 16:52

  3. core-ci voted on patch set 1 V -1 11/26/22, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34262

  4. Stefan Bürk abandoned the change 11/26/22, 20:43

    Not working out .... due multi service links