Review 11.5 Merged

76838[BUGFIX] Avoid undefined array key warning in LanguageService

Stefan Bürk CR +2 V +2 Easy +3 −1 updated 11/27/22, 04:45

Commit message

Guard invalid array key access in LanguageServices, also it
relates to an invalid xliff translation identifier. However,
the PHP warning should be guarded properly.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Stefan Bürk uploaded patch set 1 11/26/22, 17:42

  2. core-ci voted on patch set 1 V +1 11/26/22, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34264

  3. Oliver Klee voted on patch set 1 CR +1 11/26/22, 18:34

  4. Oliver Klee voted on patch set 1 V +1 11/26/22, 18:34

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 11/26/22, 21:49

  6. Stefan Bürk voted on patch set 1 V +2 CR +2 11/27/22, 04:45

  7. Stefan Bürk merged patch set 2 11/27/22, 04:45