Review main Merged

76842[TASK] Improve usability of "Create Administrative User" function

Torben Hansen CR +2 V +2 Easy +11 −6 updated 11/29/22, 13:15

Commit message

When the "Create Administrative User" is used in install tool, all
input fields are cleared regardless of, if a new user has been created
or not. This makes it impossible to correct possible validation errors
and the users has to re-enter all fields from scratch.

With this patch, input fields get only cleared, when the new user has
successfully been created.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1014

  1. Torben Hansen uploaded patch set 1 11/27/22, 18:54

  2. Torben Hansen updated the commit message in patch set 2 11/27/22, 18:56

  3. core-ci voted on patch set 1 V +1 11/27/22, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34286

  4. core-ci voted on patch set 2 V +1 11/27/22, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34287

  5. Torben Hansen uploaded patch set 3 V +1 11/28/22, 06:35

  6. core-ci voted on patch set 3 V +1 11/28/22, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34302

  7. Andreas Kienast commented on patch set 3 11/28/22, 07:09

    create-admin.ts:84

    Couldn't we clear the values here instead of setting a helper variable?
  8. Torben Hansen uploaded patch set 4 V +1 11/28/22, 14:38

  9. Torben Hansen commented on patch set 4 11/28/22, 14:40

    create-admin.ts:84 Reply

    Done
  10. core-ci voted on patch set 4 V +1 11/28/22, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34322

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 11/29/22, 08:25

  12. Markus Klein voted on patch set 4 CR +1 11/29/22, 13:05

  13. Andreas Kienast voted on patch set 4 V +2 CR +2 11/29/22, 13:15

  14. Andreas Kienast merged patch set 5 11/29/22, 13:15