Review main Merged

76843[TASK] Streamline AbstractUserAuthentication->removeCookie() usage

Benni Mack CR +2 V +2 Easy +3 −14 updated 11/28/22, 14:02

Commit message

This change unifies TYPO3 Cores handling
of calling the mostly internal call of removeCookie()
method.

Functionality regarding getCookie() is also
simplified in order to consolidate all
cookie-related methods in AbstractUserAuthentication.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1621

  1. Benni Mack uploaded patch set 1 11/28/22, 08:11

  2. Benni Mack uploaded patch set 2 11/28/22, 08:18

  3. core-ci voted on patch set 1 V +1 11/28/22, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34304

  4. core-ci voted on patch set 2 V +1 11/28/22, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34305

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 11/28/22, 08:53

  6. Oliver Klee commented on patch set 2 CR -1 11/28/22, 10:43

    AbstractUserAuthentication.php:923

    This expression does not make sense to me. The way I read it, the second condition (after the `||`) is a string with a fallback to an empty string, but it used as a boolean. Either this method should actually return a string, or we should use boolean expressions after the `||`, not strings. (Also, stripslashes does not make sense for an expression that is used as a bool.) Or am I missing something here?
  7. Oliver Klee commented on patch set 2 11/28/22, 10:44

    Marking as -1 until we have resolved the thing with the strings/bools.
  8. Oliver Klee commented on patch set 2 11/28/22, 10:49

    AbstractUserAuthentication.php:923

    isset works, but it confuses how $this-setCookie works. It actually is set, but defaults to null, so this should read: if ($this->cookie instanceof Cookie) || …
  9. Benni Mack commented on patch set 2 11/28/22, 11:11

    AbstractUserAuthentication.php:923 Reply

    I think we can reduce this to isset() - thanks for the pointer.
  10. Benni Mack commented on patch set 3 CR +1 V +1 11/28/22, 11:12

    Published edit on patch set 2.
  11. Oliver Klee commented on patch set 4 11/28/22, 11:19

    Published edit on patch set 3.
  12. core-ci voted on patch set 3 V +1 11/28/22, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34312

  13. Oliver Klee commented on patch set 4 11/28/22, 11:20

    Reply

    Done

    AbstractUserAuthentication.php:923 Reply

    Done

    AbstractUserAuthentication.php:923 Reply

    Done
  14. core-ci voted on patch set 4 V -1 11/28/22, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34313

  15. Benni Mack uploaded patch set 5 V -1 11/28/22, 11:38

  16. core-ci voted on patch set 5 V +1 11/28/22, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34315

  17. Oliver Klee voted on patch set 5 CR +1 11/28/22, 11:48

  18. Andreas Kienast voted on patch set 5 V +1 CR +1 11/28/22, 13:26

  19. Stefan Bürk voted on patch set 5 V +1 CR +1 11/28/22, 14:01

  20. Andreas Kienast voted on patch set 5 V +2 CR +2 11/28/22, 14:02

  21. Andreas Kienast merged patch set 6 11/28/22, 14:02