76843[TASK] Streamline AbstractUserAuthentication->removeCookie() usage
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1621
-
Benni Mack uploaded patch set 1 11/28/22, 08:11
-
Benni Mack uploaded patch set 2 11/28/22, 08:18
-
core-ci voted on patch set 1 V +1 11/28/22, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34304
-
core-ci voted on patch set 2 V +1 11/28/22, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34305
-
Stefan Bürk voted on patch set 2 V +1 CR +1 11/28/22, 08:53
-
Oliver Klee commented on patch set 2 CR -1 11/28/22, 10:43
-
Oliver Klee commented on patch set 2 11/28/22, 10:44
Marking as -1 until we have resolved the thing with the strings/bools. -
Oliver Klee commented on patch set 2 11/28/22, 10:49
AbstractUserAuthentication.php:923isset works, but it confuses how $this-setCookie works. It actually is set, but defaults to null, so this should read: if ($this->cookie instanceof Cookie) || … -
Benni Mack commented on patch set 2 11/28/22, 11:11
AbstractUserAuthentication.php:923ReplyI think we can reduce this to isset() - thanks for the pointer. -
Benni Mack commented on patch set 3
CR +1V +111/28/22, 11:12Published edit on patch set 2. -
Oliver Klee commented on patch set 4 11/28/22, 11:19
Published edit on patch set 3. -
core-ci voted on patch set 3 V +1 11/28/22, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34312
-
Oliver Klee commented on patch set 4 11/28/22, 11:20
Reply
DoneAbstractUserAuthentication.php:923ReplyDoneAbstractUserAuthentication.php:923ReplyDone -
core-ci voted on patch set 4 V -1 11/28/22, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34313
-
Benni Mack uploaded patch set 5
V -111/28/22, 11:38 -
core-ci voted on patch set 5 V +1 11/28/22, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34315
-
Oliver Klee voted on patch set 5 CR +1 11/28/22, 11:48
-
Andreas Kienast voted on patch set 5 V +1 CR +1 11/28/22, 13:26
-
Stefan Bürk voted on patch set 5 V +1 CR +1 11/28/22, 14:01
-
Andreas Kienast voted on patch set 5 V +2 CR +2 11/28/22, 14:02
-
Andreas Kienast merged patch set 6 11/28/22, 14:02
AbstractUserAuthentication.php:923