Review main Merged

76846[TASK] Move Cookie logic out of userAuth

Benni Mack CR +2 V +2 Hard +282 −110 updated 04/24/23, 06:09

Commit message

This change moves some logic out of AbstractUserAuth
classes related to setting a cookie, and only
adds a Instruction (the behavior) so a cookie is
added only during the response.

This allows to further extract everything related
to cookie handling into a middleware in v13.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1627

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 11/28/22, 15:40

  2. core-ci voted on patch set 1 V -1 11/28/22, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34326

  1. Benni Mack uploaded patch set 2 V -1 02/10/23, 11:57

  2. Benni Mack uploaded patch set 3 02/10/23, 12:04

  3. core-ci voted on patch set 2 V -1 02/10/23, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37550

  4. core-ci voted on patch set 3 V -1 02/10/23, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37551

  5. Benni Mack uploaded patch set 4 V -1 03/19/23, 22:38

  6. core-ci voted on patch set 4 V -1 03/19/23, 23:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39211

  7. Stefan Bürk rebased onto patch set 5 V -1 03/23/23, 01:12

  8. core-ci voted on patch set 5 V -1 03/23/23, 02:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39432

  9. Benni Mack uploaded patch set 6 V -1 04/12/23, 13:59

  10. core-ci voted on patch set 6 V -1 04/12/23, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40508

  11. Benni Mack uploaded patch set 7 V -1 04/19/23, 11:17

  12. core-ci voted on patch set 7 V -1 04/19/23, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40894

  13. Benni Mack uploaded patch set 8 V -1 04/20/23, 14:52

  14. core-ci voted on patch set 8 V -1 04/20/23, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40983

  15. Benni Mack uploaded patch set 9 V -1 04/20/23, 19:22

  16. core-ci voted on patch set 9 V +1 04/20/23, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41007

  17. Benni Mack updated the commit message in patch set 10 V +1 04/20/23, 20:27

  18. core-ci voted on patch set 10 V +1 04/20/23, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41009

  19. Andreas Kienast commented on patch set 10 04/21/23, 09:54

    AbstractUserAuthentication.php:314

    Should we make this internal for now?

    SetCookieService.php:160

    This is currently unused. Was a migration forgotten?
  20. Oli Bartsch uploaded patch set 11 V +1 04/21/23, 15:19

  21. Oli Bartsch commented on patch set 11 V +1 CR +1 04/21/23, 15:24

    AbstractUserAuthentication.php:314 Reply

    Think this makes sense. @benni please revert if you think otherwise.

    SetCookieService.php:160 Reply

    Seems like migration in AbstractUserAuthentiation::isCookieSet() (as done for the other methods) has been forgotten. Changed it. @benni please revert if you think otherwise.
  22. core-ci voted on patch set 11 V +1 04/21/23, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41047

  23. Benni Mack commented on patch set 11 04/24/23, 06:00

    AbstractUserAuthentication.php:314 Reply

    Done

    SetCookieService.php:160 Reply

    Done
  24. Andreas Kienast voted on patch set 11 V +2 CR +2 04/24/23, 06:09

  25. Andreas Kienast merged patch set 12 04/24/23, 06:09