76846[TASK] Move Cookie logic out of userAuth
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php+6 −5
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php3+42 −101
- typo3/sysext/core/Classes/Http/SetCookieBehavior.phpnew+28 −0
- typo3/sysext/core/Classes/Http/SetCookieService.php3new+194 −0
- typo3/sysext/core/Documentation/Changelog/12.4/Deprecation-100173-VariousMethodsAndPropertiesInUserAuthenticationClassesNowInternal.rst+1 −0
- typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php+3 −3
- typo3/sysext/frontend/Classes/Middleware/FrontendUserAuthenticator.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
Review log 1627
Show 12 earlier messages
-
Benni Mack uploaded patch set 1 11/28/22, 15:40
-
core-ci voted on patch set 1 V -1 11/28/22, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34326
-
Benni Mack uploaded patch set 2
V -102/10/23, 11:57 -
Benni Mack uploaded patch set 3 02/10/23, 12:04
-
core-ci voted on patch set 2 V -1 02/10/23, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37550
-
core-ci voted on patch set 3 V -1 02/10/23, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37551
-
Benni Mack uploaded patch set 4
V -103/19/23, 22:38 -
core-ci voted on patch set 4 V -1 03/19/23, 23:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39211
-
Stefan Bürk rebased onto patch set 5
V -103/23/23, 01:12 -
core-ci voted on patch set 5 V -1 03/23/23, 02:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39432
-
Benni Mack uploaded patch set 6
V -104/12/23, 13:59 -
core-ci voted on patch set 6 V -1 04/12/23, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40508
-
Benni Mack uploaded patch set 7
V -104/19/23, 11:17 -
core-ci voted on patch set 7 V -1 04/19/23, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40894
-
Benni Mack uploaded patch set 8
V -104/20/23, 14:52 -
core-ci voted on patch set 8 V -1 04/20/23, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40983
-
Benni Mack uploaded patch set 9
V -104/20/23, 19:22 -
core-ci voted on patch set 9 V +1 04/20/23, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41007
-
Benni Mack updated the commit message in patch set 10
V +104/20/23, 20:27 -
core-ci voted on patch set 10 V +1 04/20/23, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41009
-
Andreas Kienast commented on patch set 10 04/21/23, 09:54
SetCookieService.php:160This is currently unused. Was a migration forgotten? -
Oli Bartsch uploaded patch set 11
V +104/21/23, 15:19 -
Oli Bartsch commented on patch set 11 V +1 CR +1 04/21/23, 15:24
AbstractUserAuthentication.php:314ReplyThink this makes sense. @benni please revert if you think otherwise.SetCookieService.php:160ReplySeems like migration in AbstractUserAuthentiation::isCookieSet() (as done for the other methods) has been forgotten. Changed it. @benni please revert if you think otherwise. -
core-ci voted on patch set 11 V +1 04/21/23, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41047
-
Benni Mack commented on patch set 11 04/24/23, 06:00
AbstractUserAuthentication.php:314ReplyDoneSetCookieService.php:160ReplyDone -
Andreas Kienast voted on patch set 11 V +2 CR +2 04/24/23, 06:09
-
Andreas Kienast merged patch set 12 04/24/23, 06:09
AbstractUserAuthentication.php:314