76858[TASK] Remove panel class usage in About module
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Nikita Hovratov +2
-
Verified V +2 Done
- Nikita Hovratov +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/Sass/component/_card.scss+15 −0
- typo3/sysext/backend/Resources/Private/Partials/About/CoreTeam.html+3 −3
- typo3/sysext/backend/Resources/Private/Partials/About/Credits.html+3 −3
- typo3/sysext/backend/Resources/Private/Partials/About/Donation.html+3 −3
- typo3/sysext/backend/Resources/Private/Partials/About/Extensions.html+4 −4
- typo3/sysext/backend/Resources/Private/Partials/About/ExternalLibraries.html+4 −4
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
Review log 2128
Show 23 earlier messages
-
Andreas Nedbal uploaded patch set 1 11/29/22, 19:41
-
core-ci voted on patch set 1 V +1 11/29/22, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34373
-
Georg Ringer voted on patch set 1 CR +1 11/29/22, 22:49
-
Andreas Kienast commented on patch set 1 11/30/22, 07:54
While you're at it, do you think it'd make sense to add the class `card-title` to the headers as well? -
Björn Jacob voted on patch set 1 V +1 CR +1 11/30/22, 08:19
-
Andreas Nedbal uploaded patch set 2
CR +1V +111/30/22, 08:37 -
Andreas Nedbal commented on patch set 2 11/30/22, 08:39
Reply
Done! -
core-ci voted on patch set 2 V +1 11/30/22, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34395
-
Björn Jacob voted on patch set 2 V +1 CR +1 11/30/22, 08:47
-
Oli Bartsch commented on patch set 2 11/30/22, 13:01
Could we backport this to 11.5 as well? -
Andreas Nedbal updated the commit message in patch set 3
CR +1V +111/30/22, 13:04 -
Andreas Nedbal commented on patch set 3 11/30/22, 13:06
Reply
Added the version as it makes sense to backport and the card classes are available there as well. -
core-ci voted on patch set 3 V +1 11/30/22, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34419
-
Oli Bartsch voted on patch set 3 V +1 CR +1 11/30/22, 13:57
-
Nikita Hovratov uploaded patch set 4
CR +1V +112/14/22, 09:24 -
Nikita Hovratov uploaded patch set 5 12/14/22, 09:28
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 12/14/22, 09:29
-
core-ci voted on patch set 4 V +1 12/14/22, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35085
-
core-ci voted on patch set 5 V +1 12/14/22, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35086
-
Oli Bartsch commented on patch set 5 V -1 12/14/22, 14:52
Padding of the table is not correct due to the panel-table class. -
Oli Bartsch uploaded patch set 6
CR +1V +112/14/22, 15:00 -
Oli Bartsch uploaded patch set 7 12/14/22, 15:03
-
Oli Bartsch voted on patch set 7 V +1 CR +1 12/14/22, 15:04
-
core-ci voted on patch set 6 V +1 12/14/22, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35107
-
core-ci voted on patch set 7 V +1 12/14/22, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35108
-
Nikita Hovratov commented on patch set 7 V +2 CR +2 12/14/22, 15:35
Reply
good catch! -
Oli Bartsch voted on patch set 7 CR +2 12/14/22, 15:52
-
Oli Bartsch merged patch set 8 12/14/22, 15:53