Review main Merged

76863[TASK] Omit header "content elements" in linkbrowser if no elements available

Georg Ringer CR +2 V +2 Easy +10 −8 updated 12/01/22, 16:03

Commit message

available

If no content elements are available to be linked to, the header should
not be rendered at all.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josef Glatz +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Georg Ringer uploaded patch set 1 11/30/22, 13:20

  2. Georg Ringer commented on patch set 1 11/30/22, 13:20

    This change is ready for review.
  3. Josef Glatz commented on patch set 1 CR +1 11/30/22, 13:26

    Looks good! Nice catch! What about adding a notice instead? Would it be more clear to the editor? Especially when you not working often in the backend.
  4. core-ci voted on patch set 1 V +1 11/30/22, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34420

  5. Josef Glatz voted on patch set 1 V +1 11/30/22, 13:37

  6. Oliver Klee voted on patch set 1 CR +1 11/30/22, 13:41

  7. Benni Mack voted on patch set 1 V +1 CR +1 12/01/22, 10:35

  8. Oli Bartsch commented on patch set 1 V +2 CR +2 12/01/22, 15:46

    Reply

    IMO this is not necessary since linking to a page "only" is a common use case.
  9. Oli Bartsch merged patch set 2 12/01/22, 15:46

  10. Josef Glatz commented on patch set 2 12/01/22, 16:03

    Thank you! Fine with that!