76863[TASK] Omit header "content elements" in linkbrowser if no elements available
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Josef Glatz +1
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Josef Glatz +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 910
-
Georg Ringer uploaded patch set 1 11/30/22, 13:20
-
Georg Ringer commented on patch set 1 11/30/22, 13:20
This change is ready for review. -
Josef Glatz commented on patch set 1 CR +1 11/30/22, 13:26
Looks good! Nice catch! What about adding a notice instead? Would it be more clear to the editor? Especially when you not working often in the backend. -
core-ci voted on patch set 1 V +1 11/30/22, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34420
-
Josef Glatz voted on patch set 1 V +1 11/30/22, 13:37
-
Oliver Klee voted on patch set 1 CR +1 11/30/22, 13:41
-
Benni Mack voted on patch set 1 V +1 CR +1 12/01/22, 10:35
-
Oli Bartsch commented on patch set 1 V +2 CR +2 12/01/22, 15:46
Reply
IMO this is not necessary since linking to a page "only" is a common use case. -
Oli Bartsch merged patch set 2 12/01/22, 15:46
-
Josef Glatz commented on patch set 2 12/01/22, 16:03
Thank you! Fine with that!