Review main Merged

76868[TASK] Add event to intercept/adjust request-token

Oliver Hader CR +2 V +2 Normal +92 −0 updated 12/05/22, 09:13

Commit message

Add new BeforeRequestTokenProcessedEvent, allowing to intercept
or adjust a RequestToken during active user authentication process.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1217

  1. Oliver Hader uploaded patch set 1 11/30/22, 17:03

  2. core-ci voted on patch set 1 V -1 11/30/22, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34430

  3. Oliver Hader uploaded patch set 2 V -1 11/30/22, 17:27

  4. Oliver Hader commented on patch set 2 11/30/22, 17:28

    No clue why unit tests were failing in previous patch-set...
  5. Oliver Hader uploaded patch set 3 11/30/22, 17:35

  6. core-ci voted on patch set 2 V -1 11/30/22, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34432

  7. core-ci voted on patch set 3 V -1 11/30/22, 17:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34433

  8. Oliver Hader uploaded patch set 4 V -1 11/30/22, 19:13

  9. core-ci voted on patch set 4 V -1 11/30/22, 19:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34437

  10. Oliver Hader uploaded patch set 5 V -1 11/30/22, 19:30

  11. core-ci voted on patch set 5 V +1 11/30/22, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34439

  12. Benni Mack commented on patch set 5 CR -1 11/30/22, 21:41

    Commit message is wrong, this is a feature
  13. Benni Mack commented on patch set 5 CR +1 11/30/22, 21:43

    Ah, OK. thanks for your info
  14. Andreas Kienast voted on patch set 5 CR +1 12/01/22, 08:18

  15. Benni Mack voted on patch set 5 V +1 12/01/22, 08:55

  16. Oliver Hader voted on patch set 5 V +2 CR +2 12/05/22, 09:13

  17. Oliver Hader merged patch set 6 12/05/22, 09:13