Review main Merged

76870[TASK] Remove conflicting card styles

Andreas Nedbal CR +2 V +2 Normal +56 −146 updated 07/11/24, 07:05

Commit message

This patch removes the Bootstrap "card" component as the
cards present in the Backend are implemented using the
classes and styling of TYPO3.

The conflict comes from a time in which Bootstrap (3.x)
only had panel-* classes and for the new card component
the classes were modelled after Bootstraps naming scheme.
This did not end up matching what Bootstrap implemented
finally, causing confusion within some developers when
using cards in the backend.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 2437

Show 712 earlier messages
  1. Andreas Nedbal uploaded patch set 1 11/30/22, 19:25

  2. core-ci voted on patch set 1 V -1 11/30/22, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34438

  3. Andreas Nedbal uploaded patch set 2 V -1 11/30/22, 19:52

  4. core-ci voted on patch set 2 V +1 11/30/22, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34442

  5. Andreas Nedbal uploaded patch set 3 V +1 12/01/22, 10:58

  6. core-ci voted on patch set 3 V +1 12/01/22, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34470

  7. Andreas Nedbal uploaded patch set 4 V +1 12/01/22, 11:37

  8. core-ci voted on patch set 4 V +1 12/01/22, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34478

  9. Andreas Nedbal uploaded patch set 5 V +1 12/01/22, 12:17

  10. core-ci voted on patch set 5 V -1 12/01/22, 12:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34487

  11. Andreas Nedbal rebased onto patch set 6 V -1 12/01/22, 12:53

  12. Andreas Nedbal uploaded patch set 7 12/01/22, 12:56

  1. core-ci voted on patch set 6 V -1 12/01/22, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34492

  2. Andreas Nedbal rebased onto patch set 8 12/01/22, 13:08

  3. core-ci voted on patch set 7 V +1 12/01/22, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34494

  4. core-ci voted on patch set 8 V +1 12/01/22, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34496

  5. Nikita Hovratov updated the commit message in patch set 9 V +1 12/01/22, 13:43

  6. core-ci voted on patch set 9 V +1 12/01/22, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34499

  7. Andreas Kienast voted on patch set 9 V +1 CR +1 12/01/22, 15:10

  8. Tobi Kretschmann commented on patch set 9 V +1 CR +1 08/03/23, 19:52

    Looks good to me. Only minimal changes in spacings, but I am totally fine with it. 😎
  9. Simon Schaufelberger commented on patch set 9 08/13/23, 14:59

    Can you please rebase this patch? Some things have been changed in the meantime and I couldn't figure out how to merge it.
  10. Andreas Nedbal uploaded patch set 10 CR +1 V +1 06/10/24, 12:20

  11. core-ci voted on patch set 10 V +1 06/10/24, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59005

  12. Georg Ringer voted on patch set 10 CR +1 06/10/24, 12:39

  13. Jasmina Ließmann commented on patch set 10 06/10/24, 12:44

    Reply

    Done
  14. Jasmina Ließmann commented on patch set 10 V -1 06/10/24, 12:53

    With the patch, the buttons are no longer displayed flush at the end of the respective card. This can be seen very clearly in the "Admin Tools" modules. For .card, display: flex, etc. should also be added.
  15. Andreas Nedbal uploaded patch set 11 CR +1 V +1 06/10/24, 13:34

  16. Andreas Nedbal commented on patch set 11 06/10/24, 13:35

    Reply

    Fixed.
  17. core-ci voted on patch set 11 V +1 06/10/24, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59012

  18. Jasmina Ließmann voted on patch set 11 CR +1 V +1 06/10/24, 14:25

  19. Benjamin Kott uploaded patch set 12 CR +1 V +1 07/11/24, 06:44

  20. core-ci voted on patch set 12 V +1 07/11/24, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61349

  21. Benjamin Kott uploaded patch set 13 V +1 07/11/24, 06:58

  22. Benjamin Franzke voted on patch set 13 CR +1 V +1 07/11/24, 07:00

  23. core-ci voted on patch set 13 V +1 07/11/24, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61351

  24. Benjamin Kott voted on patch set 13 CR +2 V +2 07/11/24, 07:05

  25. Benjamin Kott merged patch set 14 07/11/24, 07:05