76871[WIP][FEATURE] Improved view module
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/TypeScript/viewpage/main.ts+15 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-106854-EnhancedViewModule.rst3new+30 −0
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php15+41 −3
- typo3/sysext/viewpage/Resources/Private/Language/locallang.xlf+6 −0
- typo3/sysext/viewpage/Resources/Private/Templates/Show.html+0 −1
- typo3/sysext/viewpage/Resources/Public/JavaScript/main.js+1 −1
- typo3/sysext/viewpage/composer.json+1 −0
Review log 2233
Show 48 earlier messages
-
Georg Ringer uploaded patch set 1 11/30/22, 20:56
-
core-ci voted on patch set 1 V -1 11/30/22, 21:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34447
-
Georg Ringer uploaded patch set 2
V -102/17/25, 16:33 -
core-ci voted on patch set 2 V -1 02/17/25, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74257
-
Georg Ringer uploaded patch set 3
V -106/07/25, 20:17 -
core-ci voted on patch set 3 V -1 06/07/25, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80049
-
Georg Ringer uploaded patch set 4
V -106/08/25, 06:24 -
core-ci voted on patch set 4 V -1 06/08/25, 06:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80061
-
Georg Ringer uploaded patch set 5
V -106/09/25, 19:29 -
core-ci voted on patch set 5 V +1 06/09/25, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80084
-
Georg Ringer commented on patch set 5 06/09/25, 19:35
This change is ready for review. -
Oli Bartsch commented on patch set 5 06/10/25, 08:01
DropDownHtml.php:51Should we check for $html not null?ViewModuleController.php:189I think we can remove all this surrounding spans, just using icon and label. Button styling is already applied properly due to makeFullyRenderedButton().ViewModuleController.php:202Let's add a label to the button "Show QrCode" or similar.ViewModuleController.php:205Not quite sure if we should really add this as an dropdown item. Seems like a misuse of this component. What about using a normal button and on klick just open a modal size=small with the qr code? -
Garvin Hicking commented on patch set 5 06/10/25, 08:14
Feature-106854-EnhancedViewModule.rst:17How about a note to say that previewing access-restricted pages or non-published pages needs a backend login on a mobile device? That might be clear to us, but people might think that the QR code magically transfers authentication over inside the link, too. -
Benjamin Kott commented on patch set 5 CR -2 06/10/25, 09:11
Please use DropDownItem, see comment on usage. $item = GeneralUtility::makeInstance(DropDownItem::class) ->setTag('a') ->setHref('#') ->setLabel('Label') ->setTitle('Title') ->setIcon($this->iconFactory->getIcon('actions-heart')) ->setAttributes(['data-value' => '123']); $dropDownButton->addItem($item); -
Benjamin Kott voted on patch set 5 CR -1 06/10/25, 09:11
-
Benjamin Kott commented on patch set 5 06/10/25, 09:15
ViewModuleController.php:22missing dependency in viewpage -
Georg Ringer uploaded patch set 6
CR -1V +106/10/25, 19:24 -
core-ci voted on patch set 6 V -1 06/10/25, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80156
-
Benjamin Kott commented on patch set 6 CR -1 06/10/25, 19:34
ViewModuleController.php:22ReplyDoneViewModuleController.php:129Unresolvedadd it to the button directlyViewModuleController.php:189ReplyDoneViewModuleController.php:193UnresolvedGenericButtonViewModuleController.php:197UnresolvedGenericButtonViewModuleController.php:199Unresolveduse attributes instead of js classesViewModuleController.php:202ReplyDoneViewModuleController.php:202Unresolvedwell - noViewModuleController.php:204Unresolvedmissuse of a link instead of a buttonViewModuleController.php:205ReplyDoneViewModuleController.php:206Unresolvedtranslation file -
Benjamin Kott commented on patch set 6 06/10/25, 19:37
Feature-106854-EnhancedViewModule.rst:17Replygood point, must should be handled -
Benjamin Kott commented on patch set 6 06/10/25, 19:39
DropDownHtml.php:51ReplyDone -
Garvin Hicking commented on patch set 7
CR -1V -106/11/25, 10:10Published edit on patch set 6. -
Garvin Hicking commented on patch set 7 06/11/25, 10:10
Feature-106854-EnhancedViewModule.rst:17Reply Unresolveddone, feel free to adjust wording, this is just a proposal -
core-ci voted on patch set 7 V -1 06/11/25, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80186
-
Georg Ringer rebased onto patch set 8
V -106/11/25, 19:50 -
core-ci voted on patch set 8 V -1 06/11/25, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80216
-
Garvin Hicking commented on patch set 9
V -106/12/25, 04:54Published edit on patch set 8. -
core-ci voted on patch set 9 V +1 06/12/25, 05:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80227
-
Georg Ringer uploaded patch set 10
V +106/12/25, 05:41 -
core-ci voted on patch set 10 V -1 06/12/25, 05:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80232
-
Garvin Hicking commented on patch set 11
V -106/12/25, 06:12Published edit on patch set 10. -
core-ci voted on patch set 11 V +1 06/12/25, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80233
-
Georg Ringer abandoned the change 01/22/26, 20:15
abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/92448