Review main Abandoned

76871[WIP][FEATURE] Improved view module

Georg Ringer CR 0 V 0 Normal +94 −5 updated 01/22/26, 20:15

Commit message

Todo:
- Improve modal

The following improvements are added to the view module:
- option to copy the current page into the clipboard
- having a QR code to get the URL on your mobile device to have a
  preview on a real device

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 7

Review log 2233

Show 48 earlier messages
  1. Georg Ringer uploaded patch set 1 11/30/22, 20:56

  2. core-ci voted on patch set 1 V -1 11/30/22, 21:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34447

  3. Georg Ringer uploaded patch set 2 V -1 02/17/25, 16:33

  4. core-ci voted on patch set 2 V -1 02/17/25, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74257

  5. Georg Ringer uploaded patch set 3 V -1 06/07/25, 20:17

  6. core-ci voted on patch set 3 V -1 06/07/25, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80049

  7. Georg Ringer uploaded patch set 4 V -1 06/08/25, 06:24

  8. core-ci voted on patch set 4 V -1 06/08/25, 06:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80061

  1. Georg Ringer uploaded patch set 5 V -1 06/09/25, 19:29

  2. core-ci voted on patch set 5 V +1 06/09/25, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80084

  3. Georg Ringer commented on patch set 5 06/09/25, 19:35

    This change is ready for review.
  4. Oli Bartsch commented on patch set 5 06/10/25, 08:01

    DropDownHtml.php:51

    Should we check for $html not null?

    ViewModuleController.php:189

    I think we can remove all this surrounding spans, just using icon and label. Button styling is already applied properly due to makeFullyRenderedButton().

    ViewModuleController.php:202

    Let's add a label to the button "Show QrCode" or similar.

    ViewModuleController.php:205

    Not quite sure if we should really add this as an dropdown item. Seems like a misuse of this component. What about using a normal button and on klick just open a modal size=small with the qr code?
  5. Garvin Hicking commented on patch set 5 06/10/25, 08:14

    Feature-106854-EnhancedViewModule.rst:17

    How about a note to say that previewing access-restricted pages or non-published pages needs a backend login on a mobile device? That might be clear to us, but people might think that the QR code magically transfers authentication over inside the link, too.
  6. Benjamin Kott commented on patch set 5 CR -2 06/10/25, 09:11

    Please use DropDownItem, see comment on usage. $item = GeneralUtility::makeInstance(DropDownItem::class) ->setTag('a') ->setHref('#') ->setLabel('Label') ->setTitle('Title') ->setIcon($this->iconFactory->getIcon('actions-heart')) ->setAttributes(['data-value' => '123']); $dropDownButton->addItem($item);
  7. Benjamin Kott voted on patch set 5 CR -1 06/10/25, 09:11

  8. Benjamin Kott commented on patch set 5 06/10/25, 09:15

    ViewModuleController.php:22

    missing dependency in viewpage
  9. Georg Ringer uploaded patch set 6 CR -1 V +1 06/10/25, 19:24

  10. core-ci voted on patch set 6 V -1 06/10/25, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80156

  11. Benjamin Kott commented on patch set 6 CR -1 06/10/25, 19:34

    ViewModuleController.php:22 Reply

    Done

    ViewModuleController.php:129 Unresolved

    add it to the button directly

    ViewModuleController.php:189 Reply

    Done

    ViewModuleController.php:193 Unresolved

    GenericButton

    ViewModuleController.php:197 Unresolved

    GenericButton

    ViewModuleController.php:199 Unresolved

    use attributes instead of js classes

    ViewModuleController.php:202 Reply

    Done

    ViewModuleController.php:202 Unresolved

    well - no

    ViewModuleController.php:204 Unresolved

    missuse of a link instead of a button

    ViewModuleController.php:205 Reply

    Done

    ViewModuleController.php:206 Unresolved

    translation file
  12. Benjamin Kott commented on patch set 6 06/10/25, 19:37

    Feature-106854-EnhancedViewModule.rst:17 Reply

    good point, must should be handled
  13. Benjamin Kott commented on patch set 6 06/10/25, 19:39

    DropDownHtml.php:51 Reply

    Done
  14. Garvin Hicking commented on patch set 7 CR -1 V -1 06/11/25, 10:10

    Published edit on patch set 6.
  15. Garvin Hicking commented on patch set 7 06/11/25, 10:10

    Feature-106854-EnhancedViewModule.rst:17 Reply Unresolved

    done, feel free to adjust wording, this is just a proposal
  16. core-ci voted on patch set 7 V -1 06/11/25, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80186

  17. Georg Ringer rebased onto patch set 8 V -1 06/11/25, 19:50

  18. core-ci voted on patch set 8 V -1 06/11/25, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80216

  19. Garvin Hicking commented on patch set 9 V -1 06/12/25, 04:54

    Published edit on patch set 8.
  20. core-ci voted on patch set 9 V +1 06/12/25, 05:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80227

  21. Georg Ringer uploaded patch set 10 V +1 06/12/25, 05:41

  22. core-ci voted on patch set 10 V -1 06/12/25, 05:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80232

  23. Garvin Hicking commented on patch set 11 V -1 06/12/25, 06:12

    Published edit on patch set 10.
  24. core-ci voted on patch set 11 V +1 06/12/25, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80233

  25. Georg Ringer abandoned the change 01/22/26, 20:15