Review main Merged

76876[TASK] Add static backdrop to "Refresh required" modal

Andreas Kienast CR +2 V +2 Normal +50 −20 updated 12/14/22, 13:25

Commit message

If the FormEngine needs an update due to a changed field, the "Refresh
required" modal appears. It may happen easily to accidentally close the
modal by clicking the backdrop.

This patch changes said modals to use a static backdrop.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1014

  1. Andreas Kienast uploaded patch set 1 12/01/22, 16:04

  2. core-ci voted on patch set 1 V +1 12/01/22, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34512

  3. Benni Mack voted on patch set 1 V +1 CR +1 12/01/22, 21:32

  4. Andreas Kienast rebased onto patch set 2 CR +1 V +1 12/14/22, 12:44

  5. Oli Bartsch rebased onto patch set 3 12/14/22, 12:47

  6. Oli Bartsch uploaded patch set 4 12/14/22, 12:47

  7. Oli Bartsch voted on patch set 4 V +1 CR +1 12/14/22, 12:47

  8. core-ci voted on patch set 2 V +1 12/14/22, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35096

  9. core-ci voted on patch set 3 V +1 12/14/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35098

  10. Georg Ringer voted on patch set 4 V +1 CR +1 12/14/22, 13:01

  11. core-ci voted on patch set 4 V +1 12/14/22, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35099

  12. Benni Mack voted on patch set 4 V +1 CR +1 12/14/22, 13:09

  13. Oli Bartsch voted on patch set 4 V +2 CR +2 12/14/22, 13:25

  14. Oli Bartsch merged patch set 5 12/14/22, 13:25