Review 10.4 Merged

76898[BUGFIX] Allow <figure> tag outside of paragraph tags

Benni Mack CR +2 V +2 Easy +18 −3 updated 12/05/22, 23:07

Commit message

<figure> is allowed in HTML5 outside of paragraphs,
thus it should also be configured like that out-of-the-box

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figure

Since CKEditor5 is using <figure> around tables, and also
might add a <figcaption> both variants are now enabled by default.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack commented on patch set 1 12/05/22, 22:43

    Cherry Picked from branch 11.5. The following files contain Git conflicts: * typo3/sysext/core/Tests/Unit/Html/RteHtmlParserTest.php
  2. Benni Mack commented on patch set 2 12/05/22, 22:44

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 12/05/22, 22:44

  4. core-ci voted on patch set 1 V -1 12/05/22, 22:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34684

  5. core-ci voted on patch set 2 V +1 12/05/22, 22:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34685

  6. Benni Mack voted on patch set 2 V +2 CR +2 12/05/22, 23:07

  7. Benni Mack merged patch set 3 12/05/22, 23:07