Review main Merged

76915[TASK] Replace prophecy in ExtensionManagementServiceTest

Torben Hansen CR +2 V +2 Normal +39 −45 updated 12/04/22, 20:24

Commit message

Note, that this patch also fixes some useless prophecy
`->willReturn()` calls, which did not test something. Actually,
it should have been checked, if the affected methods have been
called with the given arguments.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Torben Hansen uploaded patch set 1 12/03/22, 11:37

  2. core-ci voted on patch set 1 V +1 12/03/22, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34590

  3. Oliver Klee voted on patch set 1 V +1 12/03/22, 12:01

  4. Stefan Bürk commented on patch set 1 12/03/22, 22:29

    ExtensionManagementServiceTest.php:47

    This is mock, so we should add the suffix => `$this->remoteMock`

    ExtensionManagementServiceTest.php:48

    mocke class -> `$remoteRegistryMock`

    ExtensionManagementServiceTest.php:51

    mocked class, mock suffix ...
  5. Stefan Bürk uploaded patch set 2 V +1 12/03/22, 22:53

  6. Stefan Bürk commented on patch set 2 12/03/22, 22:53

    ExtensionManagementServiceTest.php:47 Reply

    Done

    ExtensionManagementServiceTest.php:48 Reply

    Done

    ExtensionManagementServiceTest.php:51 Reply

    Done
  7. core-ci voted on patch set 2 V +1 12/03/22, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34597

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 12/03/22, 23:24

  9. Benni Mack voted on patch set 2 V +2 CR +2 12/04/22, 20:24

  10. Benni Mack merged patch set 3 12/04/22, 20:24