Review main Merged

76923[BUGFIX] Allow <figure> tag outside of paragraph tags

Benni Mack CR +2 V +2 Easy +18 −4 updated 12/05/22, 22:36

Commit message

<figure> is allowed in HTML5 outside of paragraphs,
thus it should also be configured like that out-of-the-box

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figure

Since CKEditor5 is using <figure> around tables, and also
might add a <figcaption> both variants are now enabled by default.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 710

  1. Benni Mack uploaded patch set 1 12/05/22, 14:25

  2. core-ci voted on patch set 1 V +1 12/05/22, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34635

  3. Benni Mack uploaded patch set 2 V +1 12/05/22, 14:38

  4. Benni Mack uploaded patch set 3 12/05/22, 14:41

  5. core-ci voted on patch set 2 V +1 12/05/22, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34636

  6. core-ci voted on patch set 3 V +1 12/05/22, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34637

  7. Frank Nägler voted on patch set 3 V +1 CR +1 12/05/22, 18:24

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 12/05/22, 21:31

  9. Benni Mack voted on patch set 3 V +2 CR +2 12/05/22, 22:36

  10. Benni Mack merged patch set 4 12/05/22, 22:36