Review main Merged

76936[BUGFIX] Cast integer values in Fluid ViewHelpers

Achim Fritz CR +2 V +2 Easy +3 −3 updated 12/06/22, 10:01

Commit message

Cast decimals input arguments to integer before using them in
number_format().

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Achim Fritz uploaded patch set 1 12/06/22, 08:53

  2. Oliver Klee updated the commit message in patch set 2 12/06/22, 08:58

  3. Oliver Klee voted on patch set 2 CR +1 12/06/22, 08:59

  4. core-ci voted on patch set 1 V +1 12/06/22, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34699

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 12/06/22, 09:05

  6. core-ci voted on patch set 2 V +1 12/06/22, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34700

  7. Benni Mack voted on patch set 2 V +1 CR +1 12/06/22, 09:49

  8. Benni Mack voted on patch set 2 V +2 CR +2 12/06/22, 10:01

  9. Benni Mack merged patch set 3 12/06/22, 10:01