76939[BUGFIX] Provide current request to content element preview template
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2529
Show 34 earlier messages
-
Daniel Siepmann uploaded patch set 1 12/06/22, 13:14
-
core-ci voted on patch set 1 V +1 12/06/22, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34719
-
Georg Ringer commented on patch set 1 12/06/22, 13:23
reason why not adding that to 11.5 as well? -
Daniel Siepmann commented on patch set 1 12/06/22, 13:25
Reply
I didn't notice the issues while using 11.5. But I only had a small time frame where I also had 8.1 running. 11.5 might be affected too, but I just don't know.
-
Stefan Bürk commented on patch set 1 12/06/22, 20:42
Reply
v11 had a constructor which created a request instance anyway. This has been removed in v12. That would explain why you could not reproduce it in v11. However, not sure if we may be able to replace StandaloneView here eventully with backend view ... not really into that yet. Maybe lolli could state if StandaloneView is ok here or should be replaced. -
Christian Kuhn commented on patch set 1 12/07/22, 17:30
StandardContentPreviewRenderer.php:268in general we should avoid accessing $GLOBALS['TYPO3_REQUEST']. It would be better if the method could get this provided. This may be problematic in this case, though. Did you had a look if the request could be carried around somehow? If not, this should at least have an @todo outlining what should be done to provide the request here. -
Christian Kuhn commented on patch set 1 12/07/22, 17:33
StandardContentPreviewRenderer.php:268ReplyAs a second note, it's unfortunate this construct uses StandaloneView in the first place, it should mid-term switch to BackendViewFactory, which allows overriding templates. See the commits related to this class. I think I did not change this particular usage since it gets complicated and needs a bigger overhaul of the class construct. However, it would be good to at least add yet another todo outlining would should be done to get rid of StandaloneView here, if possible. -
Daniel Siepmann commented on patch set 1 12/08/22, 06:49
StandardContentPreviewRenderer.php:268Reply> It would be better if the method could get this provided. We could provide it as a variable. But that would mean Integrators need to know they have the variable at hand and that they need to provide it to the ViewHelper … not sure whether that's a good UX from an integrator point of view. This is mostly about integrators, not developers. -
Christian Kuhn commented on patch set 1 CR -1 03/15/23, 13:11
StandardContentPreviewRenderer.php:268Replysorry, no new usages of globls typo3_request anymore. we further improved in v12 with request handling and shouldn't introduce new access to this global anymore since it's one of the next ones to get rid of. this structure has to be refactored to not rely on this global if current request needs to be provided at this point. -
Georg Ringer commented on patch set 1 03/15/23, 20:34
StandardContentPreviewRenderer.php:268Reply@daniel as a solution: what about extracting the link generation of method linkEditContent in a new method and provide the link to the view? only drawback I see would be to have it a feature. however until now we shipped our own editVH -
Daniel Siepmann commented on patch set 1 04/13/23, 07:41
StandardContentPreviewRenderer.php:268ReplyI didn't want to open pandoras box. It currently simply doesn't work, so this is a bugfix in order to fix the bug. It is the same way as within FLUIDTEMPLATE. Maybe it makes sense to keep the fix and migrate it later, when FLUIDTEMPLATE or the ViewHelper will be migrated as well? -
Benni Mack updated the commit message in patch set 2
CR -1V +105/03/23, 09:53 -
Markus Klein commented on patch set 2 07/06/23, 18:07
StandardContentPreviewRenderer.php:268ReplyJust ran into the exact same issue. This is really nasty and really difficult to debug. Please lets get a quick fix in and do the cleanup later. -
Mathias Brodala uploaded patch set 3 07/11/24, 10:23
-
Mathias Brodala commented on patch set 3 07/11/24, 10:24
Just refreshed this for main/v13 which fortunately exposes the request in the PageLayoutContext. However, for the v12 backport we will need to use $GLOBALS['TYPO3_REQUEST'] which is acceptable IMO. -
core-ci voted on patch set 3 V +1 07/11/24, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61372
-
Christian Kuhn commented on patch set 3 07/11/24, 18:12
Reply
this looks better in main and i can live with a hack in v12. -
Oli Bartsch voted on patch set 3 CR +1 07/12/24, 06:53
-
Daniel Siepmann voted on patch set 3 CR +1 07/12/24, 08:34
-
Georg Ringer voted on patch set 3 CR +1 V +1 07/12/24, 16:49
-
Markus Klein voted on patch set 3 CR +1 V +1 07/19/24, 17:53
-
Mathias Brodala uploaded patch set 4
CR +1V +109/09/24, 08:59 -
core-ci voted on patch set 4 V -1 09/09/24, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65066
-
Mathias Brodala uploaded patch set 5
V -109/09/24, 09:20 -
core-ci voted on patch set 5 V +1 09/09/24, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65070
-
Markus Klein voted on patch set 5 CR +1 V +1 09/09/24, 10:53
-
Benni Mack commented on patch set 5 CR +1 09/11/24, 07:00
Reply
DoneReply
DoneStandardContentPreviewRenderer.php:268ReplyDone -
Benni Mack voted on patch set 5 CR +2 V +2 09/12/24, 13:36
-
Benni Mack merged patch set 6 09/12/24, 13:36