Review main Merged

76993[BUGFIX] Correctly turn nodes into TypoScript references

Christian Kuhn CR +2 V +2 Normal +89 −3 updated 12/08/22, 15:35

Commit message

Given TypoScript:
    foo = foo
    foo.childfoo = childfoo
    source = source
    foo =< source

Current AST builder output:
    foo = foo
    foo.childfoo = chilfoo
    source = source

Expected AST builder output:
    foo =< source
    foo.childfoo = childfoo
    source = source

The current TypoScript AST builder fails here since
it does not turn the existing "foo" ChildNode into
a ReferenceChildNode.

The patch adds test coverage and fixes the issue.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3