Review main Merged

77028[BUGFIX] Prevent undefined global variable in BackendConfigurationManager

Oli Bartsch CR +2 V +2 Easy +9 −6 updated 12/14/22, 11:39

Commit message

$GLOBALS['TYPO3_REQUEST'] might be undefined,
e.g. in CLI context. This is now handled properly.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1011

  1. Oli Bartsch uploaded patch set 1 12/12/22, 14:11

  2. core-ci voted on patch set 1 V +1 12/12/22, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34915

  3. Benni Mack voted on patch set 1 V +1 CR +1 12/12/22, 16:09

  4. Oliver Klee voted on patch set 1 CR +1 12/12/22, 18:43

  5. Andreas Kienast commented on patch set 1 12/13/22, 12:04

    BackendConfigurationManager.php:334

    nitpick while we're at it(?): ``` $this->currentPageId ??= $this->getCurrentPageIdFromCurrentSiteRoot(); ... ```
  6. Andreas Kienast commented on patch set 1 V +1 CR +1 12/13/22, 12:08

    BackendConfigurationManager.php:334 Reply

    Done
  7. Oli Bartsch voted on patch set 1 V +2 CR +2 12/13/22, 12:09

  8. Oli Bartsch merged patch set 2 12/13/22, 12:09

  9. Oliver Klee commented on patch set 2 12/13/22, 12:12

    This bug currently breaks functional tests for extensions that are already testing with 12.1: https://github.com/TYPO3-Documentation/tea/pull/702 Would it be possible to have a quick 12.1.2 release with this fix so the extensions can have green tests again?
  10. Oliver Klee commented on patch set 2 12/13/22, 12:13

    Reply

    And thanks for the quick fix, Oliver (the not-me Oliver)! <3
  11. Oliver Klee commented on patch set 2 12/14/22, 11:39

    Reply

    Ack