Review main Abandoned

7707[BUGFIX] Typolink ignores "linkAccessRestrictedPages"

Frederic Gaus CR 0 V 0 Easy +2 −1 updated 12/08/14, 07:00

Commit message

When config.typolinkLinkAccessRestrictedPages is set, typolink ignores the
property "linkAccessRestrictedPages".

Added a condition to the if-statement which checks if the link to the
access-restricted page should be generated even though the page cannot be
accessed.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 13

  1. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    (1 inline comment)

    class.tslib_content.php:5946

    please use !empty()
  2. Tolleiv Nietsch commented on patch set 2 2 comments 05/27/13, 17:19

    I would prefer that you didn't submit this See inline comments - it seems that this introduces some duplication which can be avoided easily...
  3. Benni Mack commented on patch set 2 1 comment 05/27/13, 17:19

    I would prefer that you didn't submit this Anyone interested in sorting out this mess and clean this up (maybe in a separate function in tslib_content)
  4. Philipp Gampe commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  5. Felix Nagel commented on patch set 2 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve Looks good to me. Tested and confirmed in order to make felogin work with both getpost (redirect_url) and login as redirectMode.
  6. Andreas Bouche voted on patch set 2 V 0 05/27/13, 17:19

  7. Andreas Bouche commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  8. Frederic Gaus uploaded patch set 2 05/27/13, 17:19

  9. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  10. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  11. Benni Mack commented on patch set 2 12/08/14, 06:59

    Hey Frederic, I got no feedback from you here. Additionally, I checked the current master code base, and seeing these options, the logic works fine as it is: - typolink property "linkAccessRestrictedPages" allows to link to pages without doing an access check - config.typolinkLinkAccessRestrictedPages allows to change the actual url to something else

    class.tslib_content.php:5943 Reply

    Hey Tolleiv, these are two different checks here, I would say: typolink.linkAccessRestrictedPages = 1 sets a link even to an access restricted page config.typolinkLinkAccessRestrictedPages = 23,14,7 allows to limit the restricted pages only to the listed above.
  12. Benni Mack commented on patch set 2 12/08/14, 07:00

    I thus abandon this patch, if you need this change, please ping me, write me, whatever, but there was no comments for almost 2 years here from you or anybody else.
  13. Benni Mack abandoned the change 12/08/14, 07:00

    I thus abandon this patch, if you need this change, please ping me, write me, whatever, but there was no comments for almost 2 years here from you or anybody else.