7707[BUGFIX] Typolink ignores "linkAccessRestrictedPages"
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 13
-
Philipp Gampe commented on patch set 1 05/27/13, 17:19
(1 inline comment)class.tslib_content.php:5946please use !empty() -
Tolleiv Nietsch commented on patch set 2 2 comments 05/27/13, 17:19
I would prefer that you didn't submit this See inline comments - it seems that this introduces some duplication which can be avoided easily... -
Benni Mack commented on patch set 2 1 comment 05/27/13, 17:19
I would prefer that you didn't submit this Anyone interested in sorting out this mess and clean this up (maybe in a separate function in tslib_content) -
Philipp Gampe commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Felix Nagel commented on patch set 2 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve Looks good to me. Tested and confirmed in order to make felogin work with both getpost (redirect_url) and login as redirectMode. -
Andreas Bouche voted on patch set 2 V 0 05/27/13, 17:19
-
Andreas Bouche commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Frederic Gaus uploaded patch set 2 05/27/13, 17:19
-
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2924/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2926/ : SUCCESS -
Benni Mack commented on patch set 2 12/08/14, 06:59
Hey Frederic, I got no feedback from you here. Additionally, I checked the current master code base, and seeing these options, the logic works fine as it is: - typolink property "linkAccessRestrictedPages" allows to link to pages without doing an access check - config.typolinkLinkAccessRestrictedPages allows to change the actual url to something elseclass.tslib_content.php:5943ReplyHey Tolleiv, these are two different checks here, I would say: typolink.linkAccessRestrictedPages = 1 sets a link even to an access restricted page config.typolinkLinkAccessRestrictedPages = 23,14,7 allows to limit the restricted pages only to the listed above. -
Benni Mack commented on patch set 2 12/08/14, 07:00
I thus abandon this patch, if you need this change, please ping me, write me, whatever, but there was no comments for almost 2 years here from you or anybody else. -
Benni Mack abandoned the change 12/08/14, 07:00
I thus abandon this patch, if you need this change, please ping me, write me, whatever, but there was no comments for almost 2 years here from you or anybody else.