Review 11.5 Merged

77089[SECURITY] Avoid DoS when generating Error pages

Oliver Hader CR +2 V +2 Normal +100 −31 updated 12/13/22, 09:44

Commit message

TYPO3 now uses a lock strategy to avoid having to many request
waiting for the generation of the error page (which cannot be
generated via the external HTTP request, as there might be not
enough workers / PHP processes available during a DoS attack).
If a lock is in place, it directly returns a generic error
response instead of waiting for the lock or that the error
page is retrieved/rendered.

Additionally, if the external error page could not be retrieved
(HTTP status code other than 200), it will also create a generic
response and cache that instead. This avoids keeping requesting
for the errounous external HTTP page.

This could happen when using external HTTP requests (Guzzle) to
resolve an error page (via PageContentErrorHandler) for 404 sites.

Only TYPO3 installations using the feature "subrequestPageErrors"
via $TYPO3_CONF_VARS[SYS][features][subrequestPageErrors] = true
are not affected as the error page is generated during the
same PHP process, avoiding to create another external process.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1