Review main Merged

77115[TASK] Update PHPStan & friends

Oliver Klee CR +2 V +2 Easy +21 −16 updated 12/14/22, 08:10

Commit message

PHPStan 1.9.3 finds another potential problem and brings
some performance improvements.

Run commands:

> composer req --dev phpstan/phpstan:^1.9.3
> composer req --dev phpstan/phpstan-phpunit:^1.3.1
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Oliver Klee uploaded patch set 1 12/13/22, 11:56

  2. Oliver Klee updated the commit message in patch set 2 12/13/22, 11:57

  3. core-ci voted on patch set 2 V +1 12/13/22, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35040

  4. Andreas Kienast voted on patch set 2 V +1 CR +1 12/14/22, 07:18

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 12/14/22, 08:02

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 12/14/22, 08:10

  7. Stefan Bürk merged patch set 3 12/14/22, 08:10