Review main Merged

77123[TASK] Task allow mariadb up to v10.10 and pg 15

Jochen Roth CR +2 V +2 Normal +125 −8 updated 12/29/22, 12:00

Commit message

Currently, mariadb is only supported up to v10.6.
This has been changed up to v10.10 and jobs have been
added to the ci pipeline.

And on top v15 of postgres
has been added for testing purposes only.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1623

  1. Jochen Roth uploaded patch set 1 12/14/22, 04:38

  2. core-ci voted on patch set 1 V +1 12/14/22, 04:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35078

  3. Benni Mack commented on patch set 1 12/14/22, 11:57

    Ideally we can add these checks to v11.5 as well, so we can communicate we also support at least maria 10.9 (LTS)
  4. Jochen Roth uploaded patch set 2 V +1 12/15/22, 03:41

  5. Jochen Roth uploaded patch set 3 12/15/22, 03:45

  6. core-ci voted on patch set 2 V +1 12/15/22, 03:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35139

  7. core-ci voted on patch set 3 V +1 12/15/22, 03:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35140

  8. Jochen Roth updated the commit message in patch set 4 V +1 12/15/22, 04:12

  9. core-ci voted on patch set 4 V +1 12/15/22, 04:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35144

  10. core-ci voted on patch set 3 V -1 12/15/22, 04:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35141

  11. core-ci voted on patch set 3 V +1 12/15/22, 04:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35141

  12. Anja Leichsenring voted on patch set 4 V +1 CR +1 12/26/22, 15:56

  13. Susi Moog voted on patch set 4 V +1 CR +1 12/27/22, 08:44

  14. Oliver Klee voted on patch set 4 V +1 CR +1 12/27/22, 10:44

  15. Stefan Bürk commented on patch set 4 CR -1 12/27/22, 13:05

    will have a look on this later, thus temp -1
  16. Stefan Bürk commented on patch set 4 12/28/22, 09:38

    Reply

    for main okay ... not sure on how to distribute the runs in the backport. need to think about it before merging. thus leavint the temp -1 for now ..
  17. Stefan Bürk commented on patch set 4 12/28/22, 11:04

    temp -1: * needs helptext adjustment * will prepare backport with adjusted ci run definitions as validation

    Reply

    Missing helptext adjustment for new possible options. Will push later along with prepared backport for validation.

    runTests.sh:194

    This needs to be adjusted too (to display which is possible) - MariaDB 10.8, 10.9 and 10.10

    runTests.sh:208

    This needs to be adjusted too (to display which is possible) -> Postgres 15
  18. Stefan Bürk uploaded patch set 5 CR +1 V +1 12/29/22, 11:51

  19. Stefan Bürk commented on patch set 5 12/29/22, 11:51

    Reply

    Done

    Reply

    Done

    runTests.sh:194 Reply

    Done

    runTests.sh:208 Reply

    Done
  20. Anja Leichsenring voted on patch set 5 V +1 CR +1 12/29/22, 11:55

  21. core-ci voted on patch set 5 V +1 12/29/22, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35394

  22. Stefan Bürk voted on patch set 5 V +2 CR +2 12/29/22, 12:00

  23. Stefan Bürk merged patch set 6 12/29/22, 12:00