Review main Merged

77129[BUGFIX] Use correct element browser config in "Setup" module

Andreas Kienast CR +2 V +2 Easy +7 −6 updated 12/14/22, 15:17

Commit message

The configuration for the element browser used for the avatar field in
the "Setup" module is now properly composed to be parseable by the
concrete `FileBrowser` implementation. The correct default upload folder
is now determinable.

Additionally, the `FileBrowser` now loads the folder's icon only if the
`$selectedFolder` property is correctly set to avoid type errors.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 56

  1. Andreas Kienast uploaded patch set 1 12/14/22, 12:27

  2. core-ci voted on patch set 1 V +1 12/14/22, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35095

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 12/14/22, 13:00

  4. Georg Ringer voted on patch set 1 V +2 CR +2 12/14/22, 13:01

  5. Georg Ringer merged patch set 2 12/14/22, 13:01

  6. Andreas Kienast commented on patch set 2 12/14/22, 15:17

    post -1: avatar selection is broken now