77172[BUGFIX] Prioritize form default values over TCA overrides
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1621
-
Helmut Hummel uploaded patch set 1 12/15/22, 12:23
-
Helmut Hummel updated the commit message in patch set 2 12/15/22, 12:30
-
core-ci voted on patch set 1 V +1 12/15/22, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35169
-
core-ci voted on patch set 2 V +1 12/15/22, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35170
-
Markus Klein commented on patch set 2 12/15/22, 13:00
can we please rephrase this a little. "default values" sounds more like "defaults from somewhere in the system". I would expect that overrides do in fact override default values ;-) my suggestion: [BUGFIX] Prioritize form default values over TCA overrides -
Helmut Hummel commented on patch set 2 12/28/22, 21:18
Reply
Sure. Any suggestions? -
Markus Klein commented on patch set 2 01/05/23, 22:33
Reply
... is in my comment already. 🤔 -
Oli Bartsch commented on patch set 2 01/09/23, 07:57
I would suggest to skip 10.4 here. This is not a priority bugfix and can furthermore be easily achieved by just replacing/overriding the data provider with an own implementation, containing the bugfix. -
Oli Bartsch commented on patch set 2 01/09/23, 07:58
Additionally, lets have a test case for this.Reply
Additionally, let's extend the corresponding data provider test. -
Benni Mack commented on patch set 2 04/14/23, 10:03
any update here? As v10.4 will soon be out of our support, we should adapt or abandon this change. -
Oli Bartsch uploaded patch set 3
V +105/02/23, 11:49 -
Oli Bartsch updated the commit message in patch set 4 05/02/23, 11:50
-
Benni Mack voted on patch set 4 V +1 CR +1 05/02/23, 11:55
-
core-ci voted on patch set 3 V -1 05/02/23, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41347
-
core-ci voted on patch set 4 V -1 05/02/23, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41348
-
Oli Bartsch uploaded patch set 5
CR +1V +105/02/23, 12:01 -
core-ci voted on patch set 5 V +1 05/02/23, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41349
-
Benni Mack voted on patch set 5 V +1 CR +1 05/02/23, 12:21
-
Oli Bartsch voted on patch set 5 V +2 CR +2 05/02/23, 12:27
-
Oli Bartsch merged patch set 6 05/02/23, 12:27