Review main Merged

77182[TASK] Update to PHPStan 1.9.4

Oliver Klee CR +2 V +2 Easy +30 −15 updated 12/20/22, 16:05

Commit message

The new version finds some more potential problems.

> composer req --dev phpstan/phpstan:^1.9.4
> composer req --dev phpstan/phpstan-phpunit:^1.3.2
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 78

  1. Oliver Klee uploaded patch set 1 12/17/22, 15:17

  2. core-ci voted on patch set 1 V +1 12/17/22, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35217

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 12/17/22, 19:09

  4. Guido Schmechel voted on patch set 1 V +1 CR +1 12/17/22, 19:40

  5. Oliver Hader commented on patch set 1 12/19/22, 08:39

    phpstan-baseline.neon:1309

    Isn't this a bug in PhpStan?!
  6. Oliver Klee commented on patch set 1 12/19/22, 09:33

    phpstan-baseline.neon:1309 Reply

    I don't know. (Still, we should update so the nightly build won't fail.)
  7. Benni Mack voted on patch set 1 V +2 CR +2 12/20/22, 16:05

  8. Benni Mack merged patch set 2 12/20/22, 16:05