Review main Merged

77193[BUGFIX] Apply z-index to backend search action form

Christoph Lehmann CR +2 V +2 Easy +5 −1 updated 12/22/22, 12:55

Commit message

The element `.sticky-form-actions` now has a `z-index` applied to give
the search provider dropdown a higher priority to avoid layering issues
with the result group labels.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Guido Schmechel +1
    • Christoph Lehmann +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Guido Schmechel +1
    • Christoph Lehmann +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Christoph Lehmann uploaded patch set 1 12/20/22, 20:19

  2. core-ci voted on patch set 1 V +1 12/20/22, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35248

  3. Andreas Kienast commented on patch set 1 V -1 12/21/22, 05:59

    This breaks overlaying the result group title when scrolling down. See https://imgur.com/a/Mp0L7wH for an example.
  4. Andreas Kienast uploaded patch set 2 V +1 12/21/22, 06:12

  5. core-ci voted on patch set 2 V +1 12/21/22, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35260

  6. Christoph Lehmann voted on patch set 2 V +1 CR +1 12/21/22, 19:02

  7. Guido Schmechel voted on patch set 2 V +1 CR +1 12/22/22, 12:38

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 12/22/22, 12:55

  9. Oli Bartsch merged patch set 3 12/22/22, 12:55