Review main Merged

77196[TASK] Streamline the unit tests for ObjectStorage

Oliver Klee CR +2 V +2 Hard +375 −152 updated 12/22/22, 20:39

Commit message

Clean up the existing tests before adding new tests:

- split tests up to test for only one piece of behavior
  where possible
- make the tests more minimal
- improve test naming
- attach proper entities instead of `stdClass`
- add annotations to make use of generics
- use variables for data that should be identical
- reorder the tests to match the order of the methods
  in the tested class

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1