Review main Abandoned

77198[WIP][TASK] Cache pages queried by PageRepository::getSubpagesForPages()

Christoph Lehmann CR 0 V 0 Normal +41 −11 updated 01/17/23, 17:20

Commit message

The method is called during menu generation. Query restrictions are
basically the same as in PageRepository::getPage() plus an additional AND WHERE clause..

The resulting pages are later queried by PageRepository::getPage() so why not cache them.

Looks good so far:
- page generation without it ~ 1900 queries
- page generation with it ~ 1600 queries

Needs decision:

Add pages only to cache if $fields = '*' or return all fields always and adapt
its callers ?

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 714

  1. Christoph Lehmann uploaded patch set 1 12/21/22, 22:08

  2. Christoph Lehmann uploaded patch set 2 12/21/22, 22:12

  3. Christoph Lehmann uploaded patch set 3 12/21/22, 22:29

  4. Christoph Lehmann uploaded patch set 4 12/21/22, 22:56

  5. core-ci voted on patch set 1 V -1 12/21/22, 23:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35284

  6. core-ci voted on patch set 2 V -1 12/21/22, 23:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35285

  7. core-ci voted on patch set 3 V -1 12/21/22, 23:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35286

  8. core-ci voted on patch set 4 V -1 12/21/22, 23:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35287

  9. core-ci commented on patch set 4 12/22/22, 12:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35287

  10. core-ci commented on patch set 4 01/02/23, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35287

  11. Christoph Lehmann marked it work in progress 01/03/23, 09:21

  12. Christoph Lehmann rebased onto patch set 5 V -1 01/14/23, 19:37

  13. core-ci voted on patch set 5 V -1 01/14/23, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35800

  14. Christoph Lehmann abandoned the change 01/17/23, 17:20