Review main Merged

77200[BUGFIX] Always allow target attribute

Benni Mack CR +2 V +2 Normal +11 −100 updated 12/22/22, 12:44

Commit message

TYPO3 included xhtml_11 (output doctype)
standard when the second revision of
XHTML 1.1 was not published yet.

TYPO3's code base assumed that in some
cases the "target" attribute (in XHTML 1.0 strict and XHTML 1.1)
was not allowed, which is not correct.

See http://learningtheworld.eu/2007/xhtml-with-target/

Additional reading: https://en.wikipedia.org/wiki/XHTML#XHTML_1.1:_Module-based_XHTML

For this reason, the workarounds for XHTML 1.0 strict
and XHTML 1.1 are removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 812

  1. Benni Mack uploaded patch set 1 12/22/22, 11:56

  2. Benni Mack uploaded patch set 2 12/22/22, 12:00

  3. Benni Mack updated the commit message in patch set 3 12/22/22, 12:04

  4. core-ci voted on patch set 1 V -1 12/22/22, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35298

  5. Benni Mack uploaded patch set 4 12/22/22, 12:14

  6. core-ci voted on patch set 2 V -1 12/22/22, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35300

  7. core-ci voted on patch set 3 V -1 12/22/22, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35301

  8. core-ci voted on patch set 4 V +1 12/22/22, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35303

  9. Oliver Klee voted on patch set 4 CR +1 12/22/22, 12:30

  10. Georg Ringer voted on patch set 4 V +1 CR +1 12/22/22, 12:42

  11. Oli Bartsch voted on patch set 4 V +2 CR +2 12/22/22, 12:44

  12. Oli Bartsch merged patch set 5 12/22/22, 12:44