77205[WIP][TASK] Extract functionality from InstallUtility
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 6
- typo3/sysext/extensionmanager/Classes/Command/DeactivateExtensionCommand.php+5 −9
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+6 −9
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+6 −11
- typo3/sysext/extensionmanager/Classes/Service/ExtensionRemovalService.php1new+82 −0
- typo3/sysext/extensionmanager/Classes/Service/ExtensionUninstallService.php3new+87 −0
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+0 −104
Review log 45
-
Benni Mack uploaded patch set 1 12/22/22, 22:58
-
core-ci voted on patch set 1 V -1 12/22/22, 23:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35315
-
Oliver Klee commented on patch set 1 12/23/22, 08:40
I love the decoupling! Posted some thought on naming things and on types for the WIP.ExtensionRemovalService.php:70UnresolvedShould this be non-empty-string? (I'd imagine that this method will give nonsensical results for empty strings.)ExtensionUninstallService.php:45UnresolvedFor the new code, I'd propose make annotate $extensionKey as non-empty-string in all places.ExtensionUninstallService.php:45UnresolvedI think the wording is "deactivate" (at least that's what we used in the T3DD exam questions IIRC). Let's use that instead of "uninstall" in order to make the difference to remove more clear. Maybe then the service should also be renamed to ExtensionDeactivationService (or ExtensionDeactivateService, but I'd prefer the other name). What do you think?ExtensionUninstallService.php:54UnresolvedWe should avoid empty() for new code if possible (as it behaves in very strange ways): if ($dependentExtensions !== []) { -
Benni Mack marked it work in progress 03/24/23, 11:45
-
Benni Mack abandoned the change 10/30/23, 15:09
not going to continuing on this (no time)