Review main Merged

77234[TASK] Drop dev dependency phpspec/prophecy

Nikita Hovratov CR +2 V +2 Normal +5 −203 updated 12/29/22, 08:36

Commit message

The mocking framework prophecy is considered dead and is already dropped
in phpunit. All occurrences in the codebase have been replaced with
corresponding phpunit mocks or have been converted to functional tests.

This patch removes the composer dependency and allows to remove the
workarounds for ignoring the php platform checks in the test setup.

Run command:
> composer remove --dev \
phpspec/prophecy \
phpspec/prophecy-phpunit \
jangregor/phpstan-prophecy

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5