77241[TASK] Use strict typed properties in ext:dashboard
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 17
- typo3/sysext/dashboard/Classes/DependencyInjection/DashboardWidgetPass.php+1 −7
- typo3/sysext/dashboard/Classes/Widgets/Provider/ButtonProvider.php+5 −20
- typo3/sysext/dashboard/Classes/Widgets/Provider/SysLogButtonProvider.php+1 −13
- typo3/sysext/dashboard/Classes/Widgets/Provider/SysLogErrorsDataProvider.php+4 −16
- typo3/sysext/dashboard/Classes/Widgets/Provider/TypeOfUsersChartDataProvider.php+1 −4
- typo3/sysext/dashboard/Classes/Widgets/WidgetConfiguration.php+9 −64
- typo3/sysext/dashboard/Classes/Dashboard.php2+8 −35
- typo3/sysext/dashboard/Classes/DashboardInitializationService.php+7 −26
- typo3/sysext/dashboard/Classes/DashboardPreset.php2+7 −40
- typo3/sysext/dashboard/Classes/DashboardPresetRegistry.php+1 −1
- typo3/sysext/dashboard/Classes/DashboardRepository.php+6 −30
- typo3/sysext/dashboard/Classes/WidgetGroup.php+1 −13
- typo3/sysext/dashboard/Classes/WidgetGroupInitializationService.php+4 −14
- typo3/sysext/dashboard/Classes/WidgetGroupRegistry.php+1 −1
- typo3/sysext/dashboard/Classes/WidgetRegistry.php+1 −7
- typo3/sysext/dashboard/Tests/Unit/DashboardPresetRegistryTest.php+1 −3
- typo3/sysext/dashboard/Tests/Unit/WidgetGroupRegistryTest.php+1 −3
Review log 810
-
Torben Hansen uploaded patch set 1 01/01/23, 12:07
-
Oliver Klee commented on patch set 1 01/01/23, 12:14
DashboardPreset.php:48We should keep this annotation (then as an @param annotation) as it provides additional type information. -
core-ci voted on patch set 1 V +1 01/01/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35415
-
Torben Hansen uploaded patch set 2
V +101/01/23, 17:40 -
Torben Hansen commented on patch set 1 01/01/23, 17:40
Dashboard.php:41ReplyDoneDashboardPreset.php:48ReplyDone -
core-ci voted on patch set 2 V +1 01/01/23, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35416
-
Oliver Klee voted on patch set 2 V +1 CR +1 01/01/23, 18:24
-
Nikita Hovratov voted on patch set 2 V +1 CR +1 01/03/23, 00:54
-
Christian Kuhn voted on patch set 2 V +2 CR +2 01/05/23, 15:24
-
Christian Kuhn merged patch set 3 01/05/23, 15:24
Dashboard.php:41