Review main Merged

77241[TASK] Use strict typed properties in ext:dashboard

Torben Hansen CR +2 V +2 Hard +59 −297 updated 01/05/23, 15:24

Commit message

Many properties are already typesafe due to their type declaration
in class constructors. This patch introduces constructor property
promotion where possible and additionally adds type declarations
for some properties and function arguments.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 810

  1. Torben Hansen uploaded patch set 1 01/01/23, 12:07

  2. Oliver Klee commented on patch set 1 01/01/23, 12:14

    Dashboard.php:41

    We should keep this annotation (then as an @param annotation) as it provides additional type information.

    DashboardPreset.php:48

    We should keep this annotation (then as an @param annotation) as it provides additional type information.
  3. core-ci voted on patch set 1 V +1 01/01/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35415

  4. Torben Hansen uploaded patch set 2 V +1 01/01/23, 17:40

  5. Torben Hansen commented on patch set 1 01/01/23, 17:40

    Dashboard.php:41 Reply

    Done

    DashboardPreset.php:48 Reply

    Done
  6. core-ci voted on patch set 2 V +1 01/01/23, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35416

  7. Oliver Klee voted on patch set 2 V +1 CR +1 01/01/23, 18:24

  8. Nikita Hovratov voted on patch set 2 V +1 CR +1 01/03/23, 00:54

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 01/05/23, 15:24

  10. Christian Kuhn merged patch set 3 01/05/23, 15:24