77243[BUGFIX] Correct editor content CSS preprocessing
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Markus Klein +1
- Frank Nägler +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Frank Nägler +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2735
Show 810 earlier messages
-
Benjamin Kott uploaded patch set 1 01/02/23, 12:33
-
core-ci voted on patch set 1 V +1 01/02/23, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35425
-
Tymoteusz Motylewski commented on patch set 1 01/02/23, 13:26
-
Benjamin Kott uploaded patch set 2
V +101/04/23, 13:41 -
Benjamin Kott commented on patch set 2 01/04/23, 13:46
ScssProcessor.php:53ReplyThe 4. param of str_replace is a counter, not a limit. Adjusted the patch to use preg_quote dod not consider it nessesary, since it can only be html or body -
Benjamin Kott commented on patch set 2 01/04/23, 13:46
ScssProcessor.php:53ReplyDone -
core-ci voted on patch set 2 V +1 01/04/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35458
-
Benni Mack voted on patch set 2 V +1 CR +1 01/04/23, 19:53
-
Tymoteusz Motylewski voted on patch set 2 CR +1 01/04/23, 20:28
-
Benjamin Kott uploaded patch set 3
CR +1V +101/05/23, 08:38
-
Benjamin Kott commented on patch set 3 01/05/23, 08:43
found 2 more cases, added test cases and adjusted the regex -
core-ci voted on patch set 3 V +1 01/05/23, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35480
-
Benjamin Kott commented on patch set 3 CR -1 01/05/23, 09:48
still some more cases, will work on the patch to include these -
Benjamin Kott uploaded patch set 4
CR -1V +101/05/23, 09:49 -
core-ci voted on patch set 4 V -1 01/05/23, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35481
-
Frank Nägler voted on patch set 4 V +1 CR +1 01/05/23, 10:09
-
Benjamin Kott uploaded patch set 5
CR +1V +101/05/23, 12:41 -
Benjamin Kott commented on patch set 5 01/05/23, 12:41
Reply
Done -
core-ci voted on patch set 5 V +1 01/05/23, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35485
-
Frank Nägler voted on patch set 5 V +1 CR +1 01/05/23, 12:53
-
Christian Kuhn commented on patch set 5 01/05/23, 16:04
Neither the commit message nor the issue say much. I think it would be good to elaborate a bit on what is going from and how it is fixed. -
Benjamin Kott commented on patch set 5 01/05/23, 18:02
Reply
Sorry i, thought the test cases speak for themselves, they were not covered or replaced incorrectly before. Will try to enhance the commit message tomorrow. -
Benjamin Kott uploaded patch set 6
CR +1V +101/06/23, 08:28 -
Benjamin Kott updated the commit message in patch set 7 01/06/23, 08:31
-
Frank Nägler voted on patch set 7 V +1 CR +1 01/06/23, 08:31
-
core-ci voted on patch set 6 V +1 01/06/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35521
-
core-ci voted on patch set 7 V +1 01/06/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35522
-
Markus Klein updated the commit message in patch set 8
CR +1V +101/06/23, 11:02 -
core-ci voted on patch set 8 V +1 01/06/23, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35526
-
Markus Klein commented on patch set 8 CR +1 01/06/23, 12:40
I can't tell much about the change in the regex and how it changed. But not using a callback is for sure nicer and the new one is way more readable with the lookarounds. -
Benni Mack voted on patch set 8 CR +1 01/09/23, 08:17
-
Christian Kuhn voted on patch set 8 CR +1 01/10/23, 21:16
-
Frank Nägler voted on patch set 8 V +1 CR +1 01/10/23, 22:22
-
Georg Ringer voted on patch set 8 V +2 CR +2 01/11/23, 06:10
-
Georg Ringer merged patch set 9 01/11/23, 06:10
ScssProcessor.php:53