Review main Merged

77244[BUGFIX] Properly localize placeholder

Alexander Vogt CR +2 V +2 Easy +1 −1 updated 01/05/23, 14:19

Commit message

Due to the introduction of the "language" TCA type,
the column processing of TCA language fields in
TcaSelectItems->addData was skipped and therefore
the array conversion through the "processDatabaseFieldValue"
method was no longer applied.

The placeholder processing in TcaInputPlaceholders
however expected the tables  language field to be
an array. This is now fixed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Alexander Vogt uploaded patch set 1 01/03/23, 10:43

  2. core-ci voted on patch set 1 V +1 01/03/23, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35433

  3. Benni Mack voted on patch set 1 CR +1 01/03/23, 14:06

  4. Oli Bartsch commented on patch set 1 CR -1 01/04/23, 07:44

    On it

    TcaInputPlaceholders.php:149

    Actually this should be skipped since it's already checked with isset() in the if condition.
  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 01/04/23, 08:12

  6. Oli Bartsch commented on patch set 2 V +1 CR +1 01/04/23, 08:13

    TcaInputPlaceholders.php:149 Reply

    Done
  7. core-ci voted on patch set 2 V +1 01/04/23, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35453

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 01/05/23, 14:08

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 01/05/23, 14:13

  10. Christian Kuhn merged patch set 3 01/05/23, 14:19