Review main Merged

77245[TASK] Update to PHPStan 1.9.5

Christian Kuhn CR +2 V +2 Normal +15 −75 updated 01/03/23, 12:08

Commit message

Some bug fixes reduce list of false positives.

> composer req --dev phpstan/phpstan:^1.9.5
> composer req --dev phpstan/phpstan-phpunit:^1.3.3
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 58

  1. Christian Kuhn uploaded patch set 1 01/03/23, 10:44

  2. core-ci voted on patch set 1 V +1 01/03/23, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35434

  3. Oliver Klee voted on patch set 1 CR +1 01/03/23, 11:30

  4. Oliver Klee voted on patch set 1 V +1 01/03/23, 11:34

  5. core-ci voted on patch set 1 V -1 01/03/23, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35435

  6. core-ci voted on patch set 1 V +1 01/03/23, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35435

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 01/03/23, 12:07

  8. Christian Kuhn merged patch set 2 01/03/23, 12:08