Review main Merged

77247[BUGFIX] Always display search box in file browser

Oli Bartsch CR +2 V +2 Normal +35 −16 updated 01/05/23, 15:19

Commit message

The search box in the file browser is now displayed again,
even if no files are in the folder. This is necessary because
the search works recursively.

Actually, the search box was only displayed for an active search
with an empty result list, due to another bug. FileSearchResultInterface
is never "empty" since it's an object. This is now fixed as well.

Additionally, the flash message is improved, in case no files
are available for a search term.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 01/03/23, 12:53

  2. core-ci voted on patch set 1 V +1 01/03/23, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35438

  3. Benni Mack voted on patch set 1 V +1 CR +1 01/03/23, 13:13

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 01/05/23, 15:03

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 01/05/23, 15:19

  6. Oli Bartsch merged patch set 2 01/05/23, 15:19