77252[TASK] Provide current content object as request attribute
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 18
- typo3/sysext/extbase/Classes/Configuration/ConfigurationManager.php+1 −0
- typo3/sysext/extbase/Classes/Configuration/ConfigurationManagerInterface.php+1 −0
- typo3/sysext/extbase/Classes/ContentObject/ExtbasePluginContentObject.php+2 −2
- typo3/sysext/extbase/Classes/Core/Bootstrap.php3+12 −8
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php3+13 −25
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+0 −1
- typo3/sysext/extbase/Tests/UnitDeprecated/Mvc/Web/Routing/UriBuilderTest.php+0 −1
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+1 −1
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+2 −2
- typo3/sysext/form/Classes/Domain/Finishers/ConfirmationFinisher.php2+5 −13
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+3 −3
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Classes/Controller/FormCachingTestsController.php+2 −2
- typo3/sysext/form/Tests/Unit/Controller/FormFrontendControllerTest.php+18 −22
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php2+27 −5
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/frontend/Classes/DataProcessing/FlexFormProcessor.php+7 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/CaseContentObjectTest.php+2 −1
- typo3/sysext/frontend/Tests/Unit/DataProcessing/FlexFormProcessorTest.php+4 −0
Review log 4059
Show 2034 earlier messages
-
Helmut Hummel uploaded patch set 1 01/03/23, 17:03
-
core-ci voted on patch set 1 V -1 01/03/23, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35445
-
Oliver Klee commented on patch set 1 01/07/23, 09:08
Typo: obsolte -> obsolete -
Christian Kuhn rebased onto patch set 2
V -104/16/23, 18:38 -
Christian Kuhn updated the commit message in patch set 3 04/16/23, 18:40
-
Christian Kuhn commented on patch set 2 04/16/23, 18:40
Reply
Done -
core-ci voted on patch set 2 V -1 04/16/23, 19:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40762
-
core-ci voted on patch set 3 V -1 04/16/23, 19:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40763
-
Benni Mack commented on patch set 3 04/17/23, 07:20
GifBuilder.php:120this is not necessary, I think -
Christian Kuhn commented on patch set 3 04/17/23, 09:15
ContentObjectRenderer.php:485this is correct: we're setting the attribute whenever the request is hand over, so in setRequest(), too. it's ok to not do this in getRequest() to not do it more often than needed. however, we might want to get rid of the 3rd argument here, and force using setRequest() before start() instead, since that's more easy and avoids the overlap with setRequest(). i'll add an according @todo. -
Christian Kuhn uploaded patch set 4
V -104/17/23, 09:58 -
Christian Kuhn uploaded patch set 5 04/17/23, 10:09
-
Christian Kuhn uploaded patch set 6 04/17/23, 10:14
-
core-ci voted on patch set 5 V -1 04/17/23, 10:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40794
-
core-ci voted on patch set 6 V -1 04/17/23, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40795
-
Christian Kuhn uploaded patch set 7
V -104/17/23, 10:53 -
Christian Kuhn uploaded patch set 8 04/17/23, 11:03
-
core-ci voted on patch set 7 V -1 04/17/23, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40796
-
core-ci voted on patch set 8 V -1 04/17/23, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40797
-
core-ci voted on patch set 4 V -1 04/17/23, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40793
-
Christian Kuhn uploaded patch set 9
V -104/17/23, 12:13 -
Christian Kuhn uploaded patch set 10 04/17/23, 12:20
-
core-ci voted on patch set 9 V -1 04/17/23, 12:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40800
-
core-ci voted on patch set 10 V +1 04/17/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40801
-
Christian Kuhn commented on patch set 10 04/17/23, 15:04
ContentObjectRenderer.php:421i will change this approach: adding the attribute within setRequest() forces us to have getRequest() public, so creators can fetch the new request object again. it will be better if a creator adds the attribute itself (and thus has the new request), and then calls setRequest(). this will allow us to make getRequest() protected later, which is the way to go, since COR should be a data sink and not a provider. with v13, we should strive for having in COR-factory, which takes care of that - this is currently problematic since there are too many places that don't have the request at hand, so this needs further streamlining in v13 to not introduce an ugly factory right now. -
Christian Kuhn uploaded patch set 11
V +104/17/23, 16:00 -
core-ci voted on patch set 11 V -1 04/17/23, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40817
-
Christian Kuhn uploaded patch set 12
V -104/18/23, 09:08 -
Christian Kuhn commented on patch set 11 04/18/23, 09:08
GifBuilder.php:120Replyunsure. removed it for now. -
Christian Kuhn uploaded patch set 13 04/18/23, 09:17
-
core-ci voted on patch set 12 V -1 04/18/23, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40857
-
Christian Kuhn uploaded patch set 14 04/18/23, 10:03
-
core-ci voted on patch set 13 V -1 04/18/23, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40858
-
core-ci voted on patch set 14 V +1 04/18/23, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40861
-
Christian Kuhn updated the commit message in patch set 15
V +104/18/23, 10:33 -
Christian Kuhn uploaded patch set 16 04/18/23, 10:37
-
core-ci voted on patch set 15 V +1 04/18/23, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40862
-
core-ci voted on patch set 16 V +1 04/18/23, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40863
-
Christian Kuhn uploaded patch set 17
V +104/18/23, 10:46 -
Christian Kuhn updated the commit message in patch set 18 04/18/23, 10:50
-
core-ci voted on patch set 17 V +1 04/18/23, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40864
-
core-ci voted on patch set 18 V +1 04/18/23, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40865
-
Oli Bartsch commented on patch set 18 04/18/23, 11:20
Bootstrap.php:112Shouldn't this always be set - Not only in case $this->cObj is NULL? -
Christian Kuhn commented on patch set 18 04/18/23, 11:42
Bootstrap.php:112ReplyI think no, at least for now: Ihis case is mainly BE usage. In FE, the attribute has been attached by cObj VH or by TSFE already. I'd only extend this if really needed and I currently see no sign we do, but I may be wrong. If it turns out to be important, I'd check getAttribute() so see if it returns null, and only then attach it. And then trigger_error() the case "cObj NOT null, but no attribute given". Unsure if we should really do this already, so I'd tend to not. What do you think? -
Stefan Bürk commented on patch set 18 04/18/23, 12:47
UriBuilder.php:177Would the `currentContentObject` attribute not be missing, if we run into this fallback ? Sure, extbase request should be set properly before hand .... -
Christian Kuhn commented on patch set 18 04/18/23, 13:14
Bootstrap.php:112ReplyAckUriBuilder.php:177ReplyYeah. We don't have the cObj at this point, though. ext:form gets this right, though (i hope). getContentObject() on ConfigurationManager will be deprecated and not deleted. So when not setting the request here, one should also continue to use getContentObject(), and fetching the cObj from ConfigurationManager should be a rather seldom case in the first place. -
Stefan Bürk commented on patch set 18 04/18/23, 13:16
UriBuilder.php:177ReplyAck. Just thought about the same. -
Christian Kuhn commented on patch set 18 04/18/23, 13:16
note the goal of this patch is not to have the 'currentContentObject' *everywhere*. Current target is getting rid of getContentObject() from ConfigurationManager. We'll later see if and where this may be further needed. -
Stefan Bürk voted on patch set 18 V +1 CR +1 04/18/23, 13:21
-
Stefan Bürk voted on patch set 18 V 0 CR 0 04/18/23, 13:21
-
Christian Kuhn uploaded patch set 19
V +104/18/23, 13:23 -
Stefan Bürk voted on patch set 19 V +1 CR +1 04/18/23, 13:25
-
core-ci voted on patch set 19 V +1 04/18/23, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40875
-
Benni Mack voted on patch set 19 V +1 CR +1 04/18/23, 14:16
-
Christian Kuhn voted on patch set 19 V +1 CR +1 04/18/23, 14:19
-
Christian Kuhn voted on patch set 19 V +2 CR +2 04/18/23, 14:19
-
Christian Kuhn merged patch set 20 04/18/23, 14:20
-
Markus Klein commented on patch set 20 07/23/24, 13:56
ConfirmationFinisher.php:103This causes a regression, see: https://forge.typo3.org/issues/104462 -
Christian Kuhn commented on patch set 20 07/25/24, 10:17
ConfirmationFinisher.php:103ReplyDone