Review main Merged

77254[BUGFIX] Prevent reseting fields in create multiple pages wizard

Oli Bartsch CR +2 V +2 Easy +37 −3 updated 01/10/23, 10:44

Commit message

The "create multiple pages" wizard features the possibility
to dynamically add additional lines, which therefore allows
to create more then five pages at once.

However, since this action updates the html of the container,
previously made inputs got removed whenever additional
lines were added.

This is now fixed by setting corresponding HTML attributes
to store the inputs.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Oli Bartsch uploaded patch set 1 01/04/23, 11:01

  2. core-ci voted on patch set 1 V +1 01/04/23, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35456

  3. Benni Mack voted on patch set 1 CR +1 01/04/23, 11:17

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 01/05/23, 15:13

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 01/05/23, 15:19

  6. Oli Bartsch merged patch set 2 01/05/23, 15:19

  7. Oli Bartsch commented on patch set 2 01/10/23, 10:44

    NOTE: Backport not necessary! The bug only exists in main and was most likely introduced with #98280.