Review main Merged

77258[FEATURE] Respect record types in new record wizard

Stefan Froemken CR +2 V +2 Hard +752 −76 updated 09/23/25, 05:50

Commit message

The new record wizard, accessible from the list module, now
also supports the record type of each table.

The list of new record links can be modified by
new PSR-14 ModifyCreationLinksOfNewRecordsEvent.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 4263

Show 2638 earlier messages
  1. Stefan Froemken uploaded patch set 1 01/04/23, 19:01

  2. core-ci voted on patch set 1 V -1 01/04/23, 19:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35469

  3. Stefan Froemken updated the commit message in patch set 2 V -1 01/04/23, 19:18

  4. core-ci voted on patch set 2 V -1 01/04/23, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35470

  5. Stefan Froemken uploaded patch set 3 V -1 01/04/23, 19:41

  6. core-ci voted on patch set 3 V -1 01/04/23, 19:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35471

  7. Stefan Froemken uploaded patch set 4 V -1 01/04/23, 20:07

  8. core-ci voted on patch set 4 V -1 01/04/23, 20:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35472

  9. Stefan Froemken uploaded patch set 5 V -1 01/04/23, 21:18

  10. core-ci voted on patch set 5 V +1 01/04/23, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35473

  11. Oli Bartsch commented on patch set 5 CR -1 01/05/23, 12:57

    Hi Stefan, I really like the patch idea. I therefore did a quick review. Please have a look at my comments. As soon as the FormEngine dependency got resolved, I'll definitely do an in deep review.

    ModifyCreationLinksOfNewRecordsEvent.php:23

    Could we add some kind of test for this new event?

    ModifyCreationLinksOfNewRecordsEvent.php:27

    Let's use constructor property promotion here. I would also like to see a PHPDoc, describing the arrays' content/structure.

    ModifyCreationLinksOfNewRecordsEvent.php:41

    We might want to add more convenience methods to the event, e.g. "getGroupedLink(string $identifier)" or "addGroupedLink(string $identifier, array $configuration)".

    NewRecordController.php:56

    This class should not add inherit from FormEngine. The AbstractItemProvider is only to be used by Data providers.

    NewRecordController.php:346

    I suggest "ModifyNewRecordCreationLinksEvent". We could might also want to add a bit more context to the event, I think of e.g. related page TSconfig or the current PSR-7 Request. What do you think?

    Feature-99459-RespectRecordTypeWhileCreatingNewRecords.rst:24

    The RST should at least contain an example for the new Event. We might also add some information about the available methods.
  12. Stefan Froemken uploaded patch set 6 CR -1 V +1 01/05/23, 18:15

  13. Stefan Froemken commented on patch set 5 01/05/23, 18:17

    Reply

    Ack

    ModifyCreationLinksOfNewRecordsEvent.php:23 Reply

    Done

    ModifyCreationLinksOfNewRecordsEvent.php:27 Reply

    Done

    ModifyCreationLinksOfNewRecordsEvent.php:41 Reply

    Done

    NewRecordController.php:56 Reply

    I'm not a fan to have the same code at multiple places. Any ideas how to streamline these methods?

    NewRecordController.php:346 Reply

    Done

    Feature-99459-RespectRecordTypeWhileCreatingNewRecords.rst:24 Reply

    Done
  14. core-ci voted on patch set 6 V -1 01/05/23, 18:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35506

  15. Chris Müller commented on patch set 6 01/05/23, 18:48

    Feature-99459-RespectRecordTypeWhileCreatingNewRecords.rst:87

    "identifier" is missing, "event" is superfluous since v11, also mind the indentation.
  16. Stefan Froemken commented on patch set 6 01/05/23, 21:10

    Feature-99459-RespectRecordTypeWhileCreatingNewRecords.rst:87 Reply

    "identifier" is just for sorting. So IMO not "missing". "event" is still needed to know when a listener has to be executed: https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Events/EventDispatcher/Index.html Indentation was a copy from here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549/19/typo3/sysext/core/Documentation/Changelog/master/Feature-29342-ImproveValidatorTask.rst#90 Just see that there are also spaces missing.
  17. Stefan Froemken uploaded patch set 7 V -1 01/05/23, 21:20

  18. Stefan Froemken commented on patch set 6 01/05/23, 21:21

    Feature-99459-RespectRecordTypeWhileCreatingNewRecords.rst:87 Reply

    Done
  19. core-ci voted on patch set 7 V +1 01/05/23, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35509

  20. Christian Kuhn commented on patch set 7 01/10/23, 17:59

    Hey. In general I like the idea to improve this "wizard". However I think there is more to think about before we introduce the types feature and an event (which is hard to adapt in case we want to change the module later): * It would be good if the event does not receive the fully parsed links, but only the arguments for existing things. This would allow the event to adapt existing links easily. * To not feed the rendered links to the event, it would be good to move the link generation to fluid and only have the arguments prepared on PHP side. * To generate the links in fluid, the inline HTML of the controller should be refactored out into fluid templates. In general all places that currently use a variable accessing prepared html should vanish. This wizard is one of those controllers that have not been properly refactored in this regard. * The 'type dropdown' from FormEngine is somehow bound to the table name itself: Look at my screenshot I added to the forge issue: In the "content" section there are now 3 entries, and it's not clear anymore they are all "collections". In FormEngine, this is much more clear, since "collection" is part of the h1 title. A similar thing happens for indexed_search with the "-" record. It seems we at least need a combination of table title and record type to reduce confusion? * Extending AbstractItemProvider in a controller is not ok. If we want to have the types rendered here, we should extract code from the Abstract to some service and see which other parts of the backend could benefit from that as well. * We may want to think about the module in more general while we are at it: I could imagine we completely leave out the "Create new content element" - content elements should only be created using the page module to get for instance 'colPos' right. I could also imagine separating the "create page" stuff to an own button and an own controller, maybe skipping the "after" and "inside" option and rendering the "PagePositionMap" only (which needs a fluidification as well). This would leave us with only non-pages and non-tt_content records for this module, which is the main target the list module is good for. We may also want to put all that stuff into modals to streamline look & feel with the page module. All in all I think we need to put more effort into this. The current state can not make it due to the inheritance from the FormEngine abstract alone, and it would be much better to separate the HTML out of the controller before we add some event that nails API. We should also think about the future of non-pages non-tt_content generation and streamline how it should look like on this level. What do you think?
  21. Christian Kuhn voted on patch set 7 CR -1 01/10/23, 17:59

  22. Oliver Klee commented on patch set 7 10/08/23, 13:43

    How should we proceed here?
  23. Oliver Klee wrote 08/25/24, 10:12

    Removed cc Oliver Klee.
  24. Benni Mack commented on patch set 7 09/02/24, 12:21

    Anyone up for revisiting this change? I think this should be fairly easy to do in a few hours with the new TcaSchema API to support this.
  25. Benni Mack uploaded patch set 8 CR -1 V +1 09/04/24, 22:04

  26. core-ci voted on patch set 8 V -1 09/04/24, 22:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64817

  27. Benni Mack commented on patch set 9 V -1 09/04/24, 22:14

    Published edit on patch set 8.
  28. core-ci voted on patch set 9 V -1 09/04/24, 22:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64821

  29. Benni Mack uploaded patch set 10 V -1 03/21/25, 20:15

  30. Benni Mack commented on patch set 10 03/21/25, 20:16

    NewRecordController.php:56 Reply

    done
  31. core-ci voted on patch set 10 V -1 03/21/25, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75981

  32. Benni Mack uploaded patch set 11 V -1 04/11/25, 14:47

  33. Benni Mack commented on patch set 11 04/11/25, 14:47

    Reply

    Done
  34. Benni Mack commented on patch set 11 04/11/25, 14:49

    I really like this change to happen, but Christian's feedback still applies. 1. Is there a Backend UX styleguide on how such dialogs should look like? moving this into a modal might be easy, but then it'd be cool it'd look like the new content element wizard. 2. How are subgroups clustered and how are their labels defined? Maybe this is a first step, and we move forward with the second step afterwards, as Lolli addressed?
  35. core-ci voted on patch set 11 V -1 04/11/25, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77544

  36. Benni Mack commented on patch set 12 V -1 04/11/25, 14:58

    Published edit on patch set 11.
  37. core-ci voted on patch set 12 V -1 04/11/25, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77546

  38. Benni Mack uploaded patch set 13 V -1 04/11/25, 15:24

  1. core-ci voted on patch set 13 V +1 04/11/25, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77550

  2. Andreas Kienast commented on patch set 13 04/22/25, 13:45

    I've built another patch (https://review.typo3.org/c/Packages/TYPO3.CMS/+/89195) that reworks some internals. I'd like to have this patch merged first (or abandoned). Why? The linked patch change the internal structure of the "tRows" array, which is absolutely necessary for the functionality. The structure is exposed via events in this patch, which makes further changes afterwards a breaking change. Thoughts?
  3. Benni Mack commented on patch set 13 08/12/25, 06:19

    Reply

    @akienast@scripting-base.de, your patch is in now - we can proceed. Can you rebase please?
  4. Andreas Kienast uploaded patch set 14 V +1 08/12/25, 09:07

  5. core-ci voted on patch set 14 V +1 08/12/25, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83192

  6. Andreas Kienast commented on patch set 14 08/12/25, 09:18

    Reply

    Done
  7. Oli Bartsch uploaded patch set 15 V +1 09/22/25, 15:07

  8. core-ci voted on patch set 15 V -1 09/22/25, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85306

  9. Oli Bartsch uploaded patch set 16 V -1 09/22/25, 16:11

  10. Oli Bartsch commented on patch set 16 09/22/25, 16:11

    Reply

    I think those points are all resolved in the meantime.
  11. core-ci voted on patch set 16 V -1 09/22/25, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85316

  12. Oli Bartsch uploaded patch set 17 V -1 09/22/25, 16:28

  13. core-ci voted on patch set 17 V -1 09/22/25, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85318

  14. Oli Bartsch uploaded patch set 18 V -1 09/22/25, 17:00

  15. core-ci voted on patch set 18 V +1 09/22/25, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85325

  16. Oli Bartsch uploaded patch set 19 V +1 09/22/25, 19:31

  17. Georg Ringer uploaded patch set 20 09/22/25, 19:43

  18. core-ci voted on patch set 19 V -1 09/22/25, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85336

  19. Georg Ringer voted on patch set 19 CR +1 V +1 09/22/25, 19:44

  20. Oli Bartsch uploaded patch set 21 09/22/25, 19:54

  21. core-ci voted on patch set 20 V -1 09/22/25, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85339

  22. core-ci voted on patch set 21 V +1 09/22/25, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85343

  23. Georg Ringer voted on patch set 21 CR +1 V +1 09/22/25, 20:18

  24. Benni Mack voted on patch set 21 CR +2 V +2 09/23/25, 05:49

  25. Benni Mack merged patch set 22 09/23/25, 05:50