Review main Abandoned

7727[BUGFIX] imageLinkWrap missing text between img tag and a tag

Simon Schaufelberger CR 0 V 0 Easy +1 −1 updated 06/03/13, 20:49

Commit message

in case you link an image just with an a tag, blind people have no
description about the image that is displayed.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 8

  1. Stefan Neufeind commented on patch set 1 08/12/12, 11:02

    please abandon as suggested by Steffen Gebert
  2. Markus Klein commented on patch set 1 08/12/12, 11:02

    I would prefer that you didn't submit this Use alt attribute of <img /> for image description and title attribute of <a> to specify what what the link is doing.
  3. Markus Klein commented on patch set 1 08/12/12, 11:02

    Thanks Simon for that. Cleanup is very necessary, indeed. I think it would be best to take a look into the W3C guidelines again (WCAG 2.0 and WAI-ARIA). Maybe there're new suggestions.
  4. Steffen Gebert commented on patch set 1 08/12/12, 11:02

    I would prefer that you didn't submit this I'm also unsure, whether that makes sense.. I doubt. What about the alt attribute of the img? Also 4.7 would be missing.
  5. Steffen Gebert commented on patch set 1 08/12/12, 11:02

    Do not submit Simon, could you please abandon this change request? Will request the issue now.
  6. Simon Schaufelberger commented on patch set 1 08/12/12, 11:02

    i am not sure if this is really a bugfix since it changes the behavior of displaying images. i just pushed everything 1:1 from the forge issue to gerrit.
  7. Simon Schaufelberger commented on patch set 1 08/12/12, 11:02

    i am fine with anything as it is originally not my patch. i just wanted to clean up some very old issues on forge...
  8. Simon Schaufelberger commented on patch set 1 08/12/12, 11:02

    Abandoned abandon according as requested