Review 11.5 Merged

77277[BUGFIX] Fix exception with PHP 8.1 in ItemProcessingService

Stefan Bürk CR +2 V +2 Easy +4 −4 updated 01/06/23, 15:49

Commit message

The pageId is already passed to the functon
ItemProcessingService::getProcessingItems(). This is now used instead
of retrieving the uid / pid from the row array.

The previous behaviour could result in an exception with PHP 8.1
since the uid in the row might not be initialized if a new page
is created. If a field with itemProcFunc existed for a field
in the pages table.

The page id which was passed to the function already handled
the case of empty uid by passing the uid of the parent page.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk uploaded patch set 1 01/06/23, 15:23

  2. core-ci voted on patch set 1 V +1 01/06/23, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35538

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 01/06/23, 15:49

  4. Stefan Bürk merged patch set 2 01/06/23, 15:49