77278[TASK] Allow npm version 9.x for node builds
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 78
-
Stefan Bürk uploaded patch set 1 01/06/23, 16:00
-
Christian Kuhn commented on patch set 1 01/06/23, 16:05
can we drop npm v8 already, or are there dependencies that trigger another patch? -
Stefan Bürk commented on patch set 1 01/06/23, 16:07
Reply
if we drop npm8, tests would fail. if we remove it, it must be combined with rebuild of the nodejs16(-chrome) images having npm9. I decided to do this step wise (as plan): * allow both * rebuild/release images * remove npm8 afterwards -
core-ci voted on patch set 1 V +1 01/06/23, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35544
-
Christian Kuhn voted on patch set 1 V +1 CR +1 01/06/23, 16:21
-
Stefan Bürk voted on patch set 1 V +2 CR +2 01/06/23, 16:25
-
Stefan Bürk merged patch set 2 01/06/23, 16:25
-
Stefan Bürk commented on patch set 2 03/05/23, 02:00
backported to 12.1 with https://review.typo3.org/c/Packages/TYPO3.CMS/+/77967 Needed to get another patch in there (core ci), which is needed in case a security patch must be processed on that branch. But this one is blocking that. core node image has only npm9 and the missing relaxed constraint from this patch is needed therefore. Bending the rules and merging this without votes to get core ci working again for all branches.