Review main Merged

77290[TASK] Improve CKEditor5 Plugin handling and defaults

Benjamin Kott CR +2 V +2 Normal +99 −26 updated 01/11/23, 06:12

Commit message

This is a prepatch to handle plugins and their configuration
in general. Plugin names differ between CKEditor4 and
CKEditor5, and there is no automatic migration of Plugin
names. To keep existing configuration working, we are
providing a mapping between old and new plugin names.

When removing a plugin, we also need to remove the
configuration associated to this plugin before passing
it to CKEditor. A reasonable default for the plugin is
now provided through the migration, if no configuration
is set.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Frank Nägler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Frank Nägler +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Benjamin Kott uploaded patch set 1 01/09/23, 09:42

  2. core-ci voted on patch set 1 V -1 01/09/23, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35599

  3. Benjamin Kott uploaded patch set 2 V -1 01/09/23, 09:59

  4. core-ci voted on patch set 2 V +1 01/09/23, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35600

  5. Frank Nägler voted on patch set 2 CR +1 01/09/23, 16:20

  6. Benni Mack voted on patch set 2 V +1 CR +1 01/10/23, 09:48

  7. Frank Nägler voted on patch set 2 V +1 01/10/23, 22:22

  8. Georg Ringer voted on patch set 2 V +2 CR +2 01/11/23, 06:12

  9. Georg Ringer merged patch set 3 01/11/23, 06:12