Review main Merged

77312[BUGFIX] Ensure string return value in Uri\PageViewHelper

Georg Ringer CR +2 V +2 Easy +1 −1 updated 02/14/23, 10:59

Commit message

Force the return value to be a string if the uri to a page is generated
but the provided page is not existing or hidden and no child node is
provided.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Achim Fritz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Achim Fritz +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1011

  1. Georg Ringer uploaded patch set 1 01/10/23, 09:05

  2. Georg Ringer commented on patch set 1 01/10/23, 09:05

    This change is ready for review.
  3. Benni Mack commented on patch set 1 CR +1 01/10/23, 09:05

    Got the same report last week. Thnks for fixing
  4. Oliver Klee voted on patch set 1 CR +1 01/10/23, 09:08

  5. core-ci voted on patch set 1 V +1 01/10/23, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35632

  6. Benni Mack voted on patch set 1 V +1 01/10/23, 09:16

  7. Achim Fritz voted on patch set 1 V +1 CR +1 01/10/23, 09:34

  8. Georg Ringer voted on patch set 1 V +2 CR +2 01/10/23, 09:42

  9. Georg Ringer merged patch set 2 01/10/23, 09:42

  10. Christian Kuhn voted on patch set 1 V +1 CR +1 01/10/23, 09:43

  11. Georg Ringer commented on patch set 2 01/11/23, 14:10

    backport not needed, code completly different in 11.5